Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#3254 closed defect (fixed)

dojo.dnd._getOffset() handles border incorrectly

Reported by: bill Owned by: Eugene Lazutkin
Priority: high Milestone: 0.9beta
Component: DnD Version: 0.9
Keywords: Cc:
Blocked By: Blocking:


dojo.dnd._getOffset() handles the border incorrectly, causing exception on IE in drag move (tested with Dialog code). Also, it's inefficient, as getComputedStyle() is called over and over again.

Change History (2)

comment:1 Changed 15 years ago by bill

Resolution: fixed
Status: newclosed

(In [8903]) Refactor dojo.dnd._getOffset(), fixing problem with border calculation and making code more efficient (since getComputedValue() is only called once). Fixes #3254.

Still seeing a jump on drag move start (bug #3255), but that was happening before this code change.

comment:2 Changed 15 years ago by Eugene Lazutkin

Actually I eliminated it completely in the new code (not checked in yet) --- this function was a quick fix.

Note: See TracTickets for help on using tickets.