Opened 12 years ago

Closed 12 years ago

#3247 closed defect (fixed)

additions and fixes to initial port of Dialog

Reported by: guest Owned by: bill
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Dialog ModalDialog enhancements Cc:
Blocked By: Blocking:

Description

  • small changes to tundra.css to share icons to match tabcontainer
  • small changes to template to accomodate timernode (which will need to be addressed later anyway)
  • many changes to Dialog.js - background shows up, scopes fixed, fx to slide dialog, various other enhancements and fixes, etc ...
  • changed tests/test_Dialog.html to have more variety of dialogs and examples ...



bug: background only display's once.

Attachments (1)

Dialog.patch (16.8 KB) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by guest

Attachment: Dialog.patch added

comment:1 Changed 12 years ago by bill

Who filed this patch? Can't look at it unless you give your name and you've filed a CLA.

comment:2 in reply to:  1 Changed 12 years ago by guest

Replying to bill:

Who filed this patch? Can't look at it unless you give your name and you've filed a CLA.

pete higgins, cla on file ... didn't take my name when i put it there.

comment:3 Changed 12 years ago by bill

(In [8904]) Refactor Dialog and remove some of the more esoteric options, like background click and the blocking timers.

Should still be able to make an unclosable dialog by adjusting the CSS to not show the close button.

Also includes some changes from 3247 (refs #3247), but I'd like for the more advanced dialog features (like the timers) to go in a dojox version, if they are really needed.

Refs #2815.

comment:4 Changed 12 years ago by bill

Component: DijitDojox
Owner: changed from bill to Tom Trenka

comment:5 Changed 12 years ago by alex

(In [8925]) ensure that repeated showings of a dialog continue to show the background. Improve background show/hide to actually fade things in and out. We want dialogs to be visually attractive. More work on transitions may be in order (e.g., Lightbox effects). Refs #3247

comment:6 Changed 12 years ago by Tom Trenka

Component: DojoxDijit
Owner: changed from Tom Trenka to bill

Not sure I should own this ticket; seems like it's a Dialog ticket (which is in Dijit, IIRC?) I think Korentag owns, but I'm not sure...

comment:7 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

OK, this ticket is confusing; I added some of the stuff from the patch into Dijit, but things like timers etc I won't put into the Dialog widget in Dijit. If we want those advanced features maybe could make a super-dialog widget in Dojox. Actually I wrote that above. Anyway, closing this bug for now.

Note: See TracTickets for help on using tickets.