Opened 15 years ago

Closed 14 years ago

Last modified 13 years ago

#324 closed defect (fixed)

[patch][need cla] Using Dojo in a XUL page fails to locate last script element

Reported by: [email protected] Owned by: alex
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc: [email protected]
Blocked By: Blocking:

Description

In Mozilla XUL, Dojo complains about the "Last script element (out of X) has no src", probably because we are using <xul:script> to pull in the Dojo JavaScript?. The <xul:script> element follows the more verbose XML DOM APIs, using scriptElement.getAttribute('src') rather than scriptElement.src to access the "src" attribute.

Attachments (1)

dojo-xul.patch (17.7 KB) - added by [email protected] 15 years ago.
Use DOM element.getAttribute("src") instead of element.src to work in XUL as well.

Download all attachments as: .zip

Change History (10)

Changed 15 years ago by [email protected]

Attachment: dojo-xul.patch added

Use DOM element.getAttribute("src") instead of element.src to work in XUL as well.

comment:1 Changed 15 years ago by anonymous

Milestone: 0.3release
Owner: changed from anonymous to alex

comment:2 Changed 14 years ago by alex

Milestone: 0.3release0.3.1

the Flock hostenv_chrome.js has not yet been submitted with a CLA. Punting in the hopes that they'll submit it.

comment:3 Changed 14 years ago by alex

Cc: [email protected] added
Milestone: 0.3.10.4

punt!

comment:4 Changed 14 years ago by dylan

Summary: Using Dojo in a XUL page fails to locate last script element[patch][need cla] Using Dojo in a XUL page fails to locate last script element

Unfortunately, we waited too long to deal with this complex of a patch before 0.4, and I still don't think we have a CLA filed on this patch

comment:5 Changed 14 years ago by dylan

Milestone: 0.40.4.1

comment:6 Changed 14 years ago by alex

ok, just looked at the patch, and it's entirely lame. Most of the "changes" are bogus whitespace diffs that should get stripped out. I'll try to figure out what the substantive changes are.

comment:7 Changed 14 years ago by alex

Status: newassigned

turns out that in that line-noise of a patch, there was a one-line change. I'll apply it and mark the bug fixed as I don't know if we'll ever get a CCLA out of Flock.

comment:8 Changed 14 years ago by alex

Resolution: fixed
Status: assignedclosed

seems an equivalent patch has already been applied. See line 32 of hostenv_browser.js.

Marking fixed.

comment:9 Changed 13 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.