Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3225 closed defect (fixed)

dojo.hasClass/addClass/removeClass fail in some cases

Reported by: Eugene Lazutkin Owned by: Eugene Lazutkin
Priority: high Milestone: 0.9beta
Component: General Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Not every DOM implementation exposes className as a member variable.

Change History (6)

comment:1 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [8846]) Replaces direct access to className to indirect getAttribute(), which is better supported. Minor performance improvement for dojo.addClass(). Fixes #3225.

comment:2 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed

(In [8848]) Replaces the last instance of direct access to className to indirect getAttribute(). Fixes #3225.

comment:3 Changed 12 years ago by Eugene Lazutkin

Summary: dojo.hasClass/addClass/removeClass fil in some casesdojo.hasClass/addClass/removeClass fail in some cases

comment:4 Changed 12 years ago by Eugene Lazutkin

(In [8852]) Refs #3225. Mostly reverting previous changes.

comment:5 Changed 12 years ago by owen

Resolution: fixed

(In [8853]) fixes #3225 adding quick check so we don't perturb class on removeClass unless class was found

comment:6 Changed 12 years ago by Eugene Lazutkin

(In [8854]) Refs #3225. Reverted changes were moved to dojox.gfx._base. This way they can be used with SVG and VML nodes without complicating HTML versions. But it would be better, if FF were more standard-compliant in this respect. :-(

Note: See TracTickets for help on using tickets.