StackContainer: publish event for unselect

[guest]

Hi dojo team,

Two enhancement proposal regarding StackContainer:

First idea:

when the 'selectChild' method of StackContainer is called, the following event is published:

dojo.event.topic.publish(this.widgetId+"-selectChild", page);

It would be interesting to have a similar event published just before changing with the old page, e.g.

dojo.event.topic.publish(this.widgetId+"-unselectChild", this.selectedChildWidget);

This would allow the developer to take action such as stopping a timer, or changing the focus...

Second idea:

Another idea would be to programmatically be able to reject the request to change the current page is some condition is not met (data not saved...)

Thanks

Yann

[bill]

Sounds reasonable.

Also, I'm wondering if we should just have one event (named after the widget id) that has a field specifying a subtype (startup, select, deselect, addChild, removeChild)

[alex]

Milestone 2.0 deleted

[Adam Peller]

assigning all Dijit bugs to Bill

[bill]

Hmm, well

StackContainer.watch("selectedChild", function(name, o, n){ ... })

will tell you the old child and the new child, but it's not exactly the same since the timing probably happens after the transition is complete.

I'm moving away from the subscribe/publish model for notification, but consider adding a notificatication like

StackContainer.on("unselect-child", ...)

[bill]

Besides watch()'ing StackContainer.selectedChild, you can also watch "selected" for an individual child. Given that I want to move away from topics in 2.0 anyway, I think that's enough.