Opened 12 years ago

Closed 12 years ago

#3213 closed enhancement (fixed)

[patch][ccla]Flash get/putMultiple API

Reported by: Adam Peller Owned by: bradneuberg
Priority: high Milestone: 0.9
Component: Storage/Flash Version: 0.9
Keywords: Cc: Brad Neuberg, jcerruti@…
Blocked By: Blocking:

Description

Another patch from Julian cerruti to provide an API to batch transactions to flash which, he feels, is more efficient, though #2495 does cover the fundamental performance problem.

Attachments (2)

dojo-flash-multiple-ops.diff (7.0 KB) - added by Adam Peller 12 years ago.
patch from Julian Cerruti (IBM, CCLA)
flash.diff (14.4 KB) - added by Adam Peller 12 years ago.
Updated patch from Julian against 0.9. Includes patch for #3266

Download all attachments as: .zip

Change History (15)

Changed 12 years ago by Adam Peller

patch from Julian Cerruti (IBM, CCLA)

comment:1 Changed 12 years ago by Adam Peller

Cc: jcerruti@… added

Julian informs me that he feels this is actually fairly important and that he has measured this as another "two additional orders of magnitude improvement in the per-item storage time. In short: storing 100 items takes the same time than storing a single item." Because it's additional APIs and I'm not sure how it fits in the overall system, I'm leaving this as an enhancement.

comment:2 Changed 12 years ago by dylan

With Brad gone for a couple more weeks, it would be nice to have this reviewed by Tom and Alex.

comment:3 Changed 12 years ago by Adam Peller

Milestone: 0.9

comment:4 Changed 12 years ago by Tom Trenka

Initial review suggests that this needs to be ported over to 0.9 before any patches can be applied; it looks like it was written against 0.4.

Any way we could get the patch written against DojoX Storage?

comment:5 Changed 12 years ago by bill

Milestone: 0.91.0
Owner: changed from alex to Brad Neuberg

comment:6 Changed 12 years ago by Adam Peller

Milestone: 1.00.9

comment:7 Changed 12 years ago by Adam Peller

There's a patch rotting here, and it's been suggested that this is a significant architectural issue, so I think this really ought to be looked at for 0.9 before we decide to defer.

comment:8 Changed 12 years ago by Adam Peller

Owner: changed from Brad Neuberg to bradneuberg

comment:9 Changed 12 years ago by dylan

Milestone: 0.91.0

comment:10 Changed 12 years ago by dylan

Milestone: 1.00.9

sorry, got trigger happy on pushing this one out...

Changed 12 years ago by Adam Peller

Attachment: flash.diff added

Updated patch from Julian against 0.9. Includes patch for #3266

comment:11 Changed 12 years ago by Adam Peller

Summary: Flash get/putMultiple API[patch][ccla]Flash get/putMultiple API

comment:12 Changed 12 years ago by bradneuberg

Depends on #4198

comment:13 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [10275]) Merge Julian's patches for flush (performance; in 0.4 branch) and get/putMultiple (also for performance, parallel to support now in Gears) Rebuilt Storage swf for Flash 8, built Storage swf for Flash 6. Fixes #3213, #3266

Ported over some 0.9 references, but still unable to run test. Fails at dojox.flash.comm.put. Refs #4198 Having the unit tests running would probably help.

Note: See TracTickets for help on using tickets.