Can not create a ContentPane without source node

[guest]

It is not possible to create a new ContentPane? without source node.

// this throws no error
var div1 = document.createElement("div");
var newCp = new dijit.layout.ContentPane({id:"newCp"}, div1);

// this throws an error
var tmp = new dijit.layout.ContentPane({id:"newCp3"} );

I tested some other widgets and can create them without the source node.

[mumme]

Ok due to the way dijit._Widget is set up it means this fix would have to go in dijit._Widget constructor function. At least thats the only way I see it (without bloat in ContentPane? regarding domNode.id -> widget.id etc.).

That means we will always create a DIV if srcNodeRef isn't present. It is a simple 1 liner fix, but it might be bad for runtime on some other widgets.

===================================================================
--- _Widget.js  (revision 9539)
+++ _Widget.js  (working copy)
@@ -28,8 +28,8 @@
        //                              a stub function that you can over-ride to modify take
        //                              actions once the widget has been placed in the UI

-       // store pointer to original dom tree
-       this.srcNodeRef = dojo.byId(srcNodeRef);
+       // store pointer to original dom tree, or create a new DIV if none is supplied
+       this.srcNodeRef = dojo.byId(srcNodeRef || dojo.doc.createElement('div'));

        // For garbage collection.  An array of handles returned by Widget.connect()
        // Each handle returned from Widget.connect() is an array of handles from dojo.connect()

Question is should we really support automagical domNode construction in 0.9?

[bill]

Right, it's like you said. Most widgets don't have this issue because most widgets have templates. As for that one line fix, it's a little inefficient because for widgets with templates it's unnecessary (and creates then abandons that div node).

Hmm, let's think about this one.

[mumme]

Bill, I don't think this ticket really "belongs" to me.

I'm not involved deeply enough in the development to make this call, Its not just ContentPane?'s, its every widget without Template.

[alex]

why did this get punted? It's really really simple to fix.

[bill]

(In [11229]) Fixes #3211: automatically create node for widget if user hasn't supplied one.