Opened 12 years ago

Closed 12 years ago

#3209 closed defect (fixed)

InlineEditBox: should be copying font, height, and width from source text

Reported by: bill Owned by: haysmark
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

When you click an InlineEditBox? to edit something, the font should stay the same, like in 0.4: http://download.dojotoolkit.org/release-0.4.3/dojo-0.4.3-widget/tests/widget/test_InlineEditBox.html

In addition, when editing a paragraph of text, it should use the TextArea? widget, and should adopt the same width/height as the original text, to minimize the screen jumping.

Change History (10)

comment:1 Changed 12 years ago by Douglas Hays

0.4 only copied the style over for text boxes and not text areas.

comment:2 Changed 12 years ago by Douglas Hays

Cc: haysmark added

comment:3 Changed 12 years ago by Douglas Hays

Cc: haysmark removed
Owner: changed from Douglas Hays to haysmark

comment:4 Changed 12 years ago by bill

(In [9582]) InlineEditBox? copies the source font into its focusNode and its inline text. Refs #3209. (Patch from Mark Hays, IBM, CCLA on file)

comment:5 Changed 12 years ago by haysmark

Status: newassigned

Now just need to resize things.

comment:6 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [9774]) Added resize method for form widgets, to be used by InlineEditBox?, to match the size of the source text. Patch from Mark Hays (IBM, CCLA on file) Fixes #3209.

comment:7 Changed 12 years ago by bill

Resolution: fixed
Status: closedreopened

Actually looking at this more closely now, it's no good for TextArea? on safari or IE because it prevents the height from changing dynamically as you type text. IE's width is also too small.

comment:8 Changed 12 years ago by bill

(In [9781]) Make TextArea? resize() only sets the width; the height autosizes as normal. Refs #3209. (Patch from Mark Hays, IBM, CCLA on file)

comment:9 Changed 12 years ago by bill

(In [9782]) set renderAsHtml to false, for testing the default behavior and also to make sure newlines work correctly in the default case (they don't, currently)

refs #3209

comment:10 Changed 12 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [9793]) InlineEditBox? calls resize on its edit widget right when the edit widget displays, as opposed to page load and on value changes. Fixes #3209. Patch from Mark Hays (IBM, CCLA on file)

Note: See TracTickets for help on using tickets.