Opened 12 years ago

Closed 12 years ago

#3167 closed task (fixed)

Port Fisheye to Dojox

Reported by: guest Owned by: tk
Priority: high Milestone:
Component: Dojox Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

I've ported FisheyeList? to 0.9 dojo. I'm attaching the file if anyone is interested in adding it to svn. It's working properly in Firefox 2 and IE7. The only thing I could not port is the _onBodyOut handler (couldn't find a replace for 0.4 dojo.html.overElement). Like in the previous version, it's very slow under Firefox in Linux. Doing some profiling you can see that positioning the label its taking a long amount of time. Seems like dojo.marginBox it's very expensive. I think the best will be to "harcode" the position and not trying to center it perfectly.

Hope it helps.

Attachments (3)

FisheyeList.js (21.5 KB) - added by guest 12 years ago.
FisheyeList.css (446 bytes) - added by guest 12 years ago.
test_FishEyeList.html (3.3 KB) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by guest

Attachment: FisheyeList.js added

Changed 12 years ago by guest

Attachment: FisheyeList.css added

Changed 12 years ago by guest

Attachment: test_FishEyeList.html added

comment:1 Changed 12 years ago by alex

who ported this? We need to know to check for CLA purposes (and to use it toward potential committer status).

As for marginBox, yeah, it's known to take a lot of time. Given that the relative measures aren't going to change much, it might be possible to do that kind of calculation once and cache the results. Another option is to use the semi-public versions of those functions which may perform better.

comment:2 Changed 12 years ago by guest

It was me, Pablo Ruggia (pruggia at gmail dot com). I'll send the CLA tonight, I totally forgot about that.

comment:3 Changed 12 years ago by guest

CLA sent to carrie at dojotoolkit.org

Pablo Ruggia

comment:4 Changed 12 years ago by Tom Trenka

Milestone: 0.9beta0.9

comment:5 Changed 12 years ago by Tom Trenka

Milestone: 0.9

comment:6 Changed 12 years ago by Tom Trenka

Owner: changed from Tom Trenka to tk

Karl-- Can you review and decide whether or not to close (based on your port)?

comment:7 Changed 12 years ago by tk

Resolution: fixed
Status: newclosed

Ported copy already committed... Closing ticket, I will compare the codes after verifying the CLA with Aimee and copy any improvements I might have missed.

-Karl

Note: See TracTickets for help on using tickets.