handle null situation in JsonItemStore

[guest]

this is the test data used by the jsonItemStore:

{ identifier: 'abbr',
items: [
{ abbr:'ec', name:'Ecuador', capital:'Quito' },
{ abbr:'eg', name:'Egypt', capital:'Cairo' },
]}

it works well like this. but after I replace a value into null,for example:

{ identifier: 'abbr',
items: [
{ abbr:'ec', name:null, capital:'Quito' },
{ abbr:'eg', name:'Egypt', capital:'Cairo' },
]}

then it fails. I found the problem in dojo/data/JsonItemStore.js line281:

for(i = 0; i < arrayOfItems.length; ++i){
item = arrayOfItems[i];
for(var key in item){
var value = item[key];
if(!dojo.isArray(value)){
item[key] = [value];
}
attrNames[key]=key;
}
}

then I fixed it like this:

for(i = 0; i < arrayOfItems.length; ++i){
item = arrayOfItems[i];
for(var key in item){
var value = item[key];
if(value===null){
item[key]=[];
}else if(!dojo.isArray(value)){
item[key] = [value];
}
attrNames[key]=key;
}
}

now it can handle null situation

[Jared Jurkiewicz]

Who opened this ticket? Have they signed a CLA? The noted code can't be used without a CLA in place.

[Jared Jurkiewicz]

Working on a solution. Cannot use provided solution as submitter is unknown and CLA signature is also unknown. Plus, the solution isn't quite correct anyway.

[Jared Jurkiewicz]

Minor patch to fix null attribute case.

[Jared Jurkiewicz]

(In [8859]) Fix to handle null cases, as well as a performance fix + UT. fixes #3153

[Jared Jurkiewicz]

Tested and verified on:

Windows:

IE 6.0 IE 7.0 Firefox 2.0.0.4 Firefox 1.5.0.11 Opera 9.2

OS-X:

WebKit?.

[Jared Jurkiewicz]

Oh yeah, and also tested on SeaMonkey? 1.1.1