Opened 12 years ago

Closed 12 years ago

#3134 closed defect (fixed)

ProgressBar broken in high-contrast

Reported by: simonjb Owned by: simonjb
Priority: high Milestone: 0.9beta
Component: Accessibility Version: 0.9
Keywords: Cc: owen, bill, Becky Gibson
Blocked By: Blocking:

Description

Recent changes have broken ProgressBar in Windows high-contrast.

On FF the bar is solid and only fills a portion of the container. It obscures the text label if the bar is long enough.

On IE the bar is not visible at all.

To reproduce:

  • put Windows into high-contrast (using the Accessibility Options control panel or left-shift + alt + printscreen)
  • open dijit/tests/test_ProgressBar.html

Attachments (1)

ProgressBar.diff (7.7 KB) - added by simonjb 12 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by simonjb

Status: newassigned

Changed 12 years ago by simonjb

Attachment: ProgressBar.diff added

comment:2 Changed 12 years ago by simonjb

Cc: bill Becky Gibson added

Attached patch:

  • fixes high-contrast mode (#3134)
  • now using dijit_a11y to implement high-contrast, removed special bordered div
  • made bar visible without tundra (just dijit.css) (background-color:#aaa)
  • bar sizing is now set by percent rather than pixels (discussed on #2803)
  • fixed label positioning on vertical progress bar (#3107)
  • removed the annotate property (#3204)

Tested on:

  • Windows FF2
  • Windows IE6
  • Windows IE7
  • High-contrast Windows FF2
  • High-contrast Windows IE6
  • High-contrast Windows IE7
  • Windows Quirks-mode FF2
  • Windows Quirks-mode IE6
  • Windows Quirks-mode IE7
  • High-contrast Windows Quirks-mode FF2
  • High-contrast Windows Quirks-mode IE6
  • High-contrast Windows Quirks-mode IE7
  • Mac FF2
  • Mac recent WebKit build

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [8861]) * fixes high-contrast mode (fixes #3134)

  • now using dijit_a11y to implement high-contrast, removed special bordered div
  • made bar visible without tundra (just dijit.css) (background-color:#aaa)
  • bar sizing is now set by percent rather than pixels (fixes #2803)
  • fixed label positioning on vertical progress bar (fixes #3107)
  • removed the annotate property (fixes #3204)

Patch from Simon Bates (CLA on file)

Note: See TracTickets for help on using tickets.