Opened 13 years ago

Closed 13 years ago

#3111 closed defect (fixed)

0.9: All JsonRPC tests fail in Firefox 2.0.0.3

Reported by: Jared Jurkiewicz Owned by: Dustin Machi
Priority: high Milestone: 0.9beta
Component: IO Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

All JsonRPC tests fail in Firefox 2.0.0.3

GROUP "tests.rpc" has 4 tests to run

TypeError?: ioArgs.cancel is not a function

ERROR IN:

(function () {var d = new doh.Deferred;var td = this.svc.myecho("RPC TEST");td.addCallbacks(function (result) {if (result == "

RPC TEST ") {return true;} else {return new Error("JsonRpc?-EchoTest? test failed, resultant content didn't match");}}, function (result) {return new Error(result);});td.addBoth(d, "callback");return d;})

FAILED test: JsonRPC-EchoTest? Error: Error

ERROR IN:

(function () {var d = new doh.Deferred;var td = this.svc.contentB();td.addCallbacks(function (result) {if (result == "

Content B ") {return true;} else {return new Error("JsonRpc?-EmpytParamTest? test failed, resultant content didn't match");}}, function (result) {return new Error(result);});td.addBoth(d, "callback");return d;})

FAILED test: JsonRPC-EmptyParamTest? Error: Error

ERROR IN:

(function () {var d = new doh.Deferred;var td = this.svc.contentB();td.addCallbacks(function (result) {if (result == "

Content B ") {return true;} else {return new Error("JsonRpc_SMD_Loading_Test failed, resultant content didn't match");}}, function (result) {return new Error(result);});td.addBoth(d, "callback");return d;})

FAILED test: JsonRPC_SMD_Loading_test Error: Deferred(unfired)

ERROR IN:

(function () {var d = new doh.Deferred;var td = this.svc.webSearch({[Error: Query filter requires field and constraints separated by a "="]});td.addCallbacks(function (result) {console.debug(result);return true;if (result == "

Content B ") {return true;} else {return new Error("JsonRpc_SMD_Loading_Test failed, resultant content didn't match");}}, function (result) {return new Error(result);});td.addBoth(d, "callback");return d;})

FAILED test: JsonP_test

Change History (6)

comment:1 Changed 13 years ago by Dustin Machi

jared,

Where did you test this? If you tested it locally you will need php and teh File.php module from pear for it to work properly. Testing it here: http://archive.dojotoolkit.org/nightly/dojotoolkit/util/doh/runner.html?testModule=dojo.tests.module

The first and last test fail (expected right now). The first test fails I think because we need to do some dojo.uri stuff as it is trying to execute from the wrong URL inexplicably. The last test fails because I need to find a good result set that won't change from yahoo to test against.

comment:2 Changed 13 years ago by Dustin Machi

Owner: changed from alex to Dustin Machi

comment:3 Changed 13 years ago by Jared Jurkiewicz

I ran it locally. Is there a way you can get the tests to flag off if run locally, then? Those test failures when run locally look rather bad. You should be able to look at the absolute url being targeted and if it starts with file://, know to disable and all that.

I think I saw another browser complain about a syntax error in the rpc file as well. I believe it was Opera.

comment:4 Changed 13 years ago by Dustin Machi

(In [8993]) fix some Rpc bugs. references #3111. references #2915

comment:5 Changed 13 years ago by Dustin Machi

I don't think that making it just not error out at all is the appropriate thing to do as it will lead to things not being tested properly. Its common knowledge that some things fail due to security restrictions around file://. All that said, I do think people should know that is why these things fail, so to that end my next checkin will error out on the first,second, and fourth tests, but will do so with a messages that says those tests require a webserver and php.

comment:6 Changed 13 years ago by Dustin Machi

Resolution: fixed
Status: newclosed

(In [8994]) fixes to some rpc tests and show a useful error for tests that we know are going to fail when accessed from file://. fixes #3111

Note: See TracTickets for help on using tickets.