Opened 12 years ago

Closed 12 years ago

Last modified 7 years ago

#3085 closed defect (fixed)

Add bidi testing to Dijit

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 0.9beta
Component: Internationalization Version: 0.9
Keywords: bidi Cc: bill
Blocked By: Blocking:

Description

Attached is a clever addition from Justin Yin (IBM, CCLA) that we'd add to each of our test files. Originally, the tests were done by duplicating the entire tests/ directory. This is a lot easier to maintain, I think.

Attachments (2)

dijit-bidi-test-r8665.patch​ (15.1 KB) - added by Adam Peller 12 years ago.
from Justin Yin (IBM, CCLA)
dijit-gvt-case-textbox-9542.patch​ (50.1 KB) - added by Adam Peller 12 years ago.
GVT from Justin Yin, IBM (CCLA)

Download all attachments as: .zip

Change History (14)

Changed 12 years ago by Adam Peller

Attachment: dijit-bidi-test-r8665.patch​ added

from Justin Yin (IBM, CCLA)

comment:1 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [8693]) To test right-to-left, append "?test-bidi" to the URL. Fixes #3085.

comment:2 Changed 12 years ago by Adam Peller

(In [8694]) Add a comment. Refs #3085.

Changed 12 years ago by Adam Peller

Attachment: dijit-gvt-case-textbox-9542.patch​ added

GVT from Justin Yin, IBM (CCLA)

comment:3 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closed → reopened

comment:4 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: reopened → closed

(In [9559]) Initial revision of Global Verification Tests for Dijit. Thanks Justin Yin, IBM (CCLA) Fixes #3085.

comment:5 Changed 12 years ago by Adam Peller

(In [9562]) Add README with CLDR build instructions. Refs #3085.

comment:6 Changed 12 years ago by Adam Peller

(In [9563]) Update CLDR build instructions to include resolver.jar for faster builds. Refs #3085

comment:7 Changed 12 years ago by Adam Peller

(In [10418]) Raise attributemap branch. Merges [9989] to [10417]. Refs #3085

comment:8 Changed 12 years ago by Adam Peller

(In [10455]) Raise attributemap branch. Merge [10419] through [10454]. Refs #3085

comment:9 Changed 12 years ago by Adam Peller

(In [10470]) missing null check. refs #4424, #3085

comment:10 Changed 12 years ago by Adam Peller

(In [10841]) remove instructions on how to copy jars. Refs #3085

comment:11 Changed 8 years ago by bill

(In [23461]) Convert test to run under AMD by getting rid of document.write() calls and moving dojo.declare() etc. inside of dojo.addOnLoad(), refs #3085, #11869.

comment:12 Changed 7 years ago by bill

In [27566]:

Get i18n test files at least running again with new AMD loader:

  • remove direct <script> tags
  • move parse() calls inside dojo.ready()
  • time.html was declaring stub TimeTextBox with a format() signature different than _TextBoxMixin; use real TimeTextBox instead


Also includes lint fixes plus change to use getEnclosingWidget() rather than essentially duplicating the code, but with an error.


Not sure it's even worth having these tests though. time.html has been broken since 1.1 with no one noticing.


Refs #3085 !strict.

Note: See TracTickets for help on using tickets.