Opened 13 years ago

Closed 12 years ago

#3074 closed defect (fixed)

tab closing doesn't work on IE 7

Reported by: alex Owned by: bill
Priority: high Milestone: 0.9beta
Component: Dijit Version: 0.9
Keywords: dijit Cc:
Blocked By: Blocking:

Description

try closing the "Closeable" tab item on dijit/themes/themeTester.html.

the content pane goes away but the label doesn't. If you close the click button again, it throws an exception.

Attachments (1)

parser.js.diff (481 bytes) - added by guest 12 years ago.
[cla][patch] from nicola.rizzo+dojo@…: fixes the removeChild problem in TabContainer?

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by guest

problem exists also in IE6.

... and in IE6, tab close icon is mis-positioned by maybe 8px too far left though probabally unrelated.

mse says exception being thrown is from checking this.currentStyle on the tab button node after it has been destroyed ... in 'ie branch' of getComputedStyle

comment:2 Changed 12 years ago by guest

IE uses the removeChild(...) method in Container.js instead of the one in PageContainer?.js

Nicola

comment:3 in reply to:  2 ; Changed 12 years ago by guest

Replying to guest:

IE uses the removeChild(...) method in Container.js instead of the one in PageContainer?.js

Nicola

Pardon: IE sees an anonymous function instead of PageContainer?.removeChild(page); if I replace the removeChild call with the implementation, all works fine. :?

N

comment:4 in reply to:  3 Changed 12 years ago by guest

Replying to guest: Same issue in LayoutContainer?, SplitContainer?, AccordionContainer?...

Nicola

Replying to guest:

IE uses the removeChild(...) method in Container.js instead of the one in PageContainer?.js

Nicola

Pardon: IE sees an anonymous function instead of PageContainer?.removeChild(page); if I replace the removeChild call with the implementation, all works fine. :?

N

Changed 12 years ago by guest

Attachment: parser.js.diff added

[cla][patch] from nicola.rizzo+dojo@…: fixes the removeChild problem in TabContainer?

comment:5 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [9192]) Every node on IE defines "removeChild" as a native attribute, but we want to ignore this attribute unless the user has actually specified it. Thanks to Nicola Rizzo (CLA on file) for this patch. Fixes #3074.

Note: See TracTickets for help on using tickets.