Opened 15 years ago
Closed 15 years ago
#3069 closed task (fixed)
Make theme tester page
Reported by: | owen | Owned by: | owen |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Make a page for one-stop-shopping of testing your theme. Currently checked in as: /dijit/themes/themeTester.html .
Attachments (2)
Change History (18)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
comment:4 follow-up: 5 Changed 15 years ago by
[pete higgins]
bug: does not render in IE6, Opera, or Khtml ... as in "at all" ... IE complains with cryptic error, Khtml only shows tree, Opera shows tree without icons or focusing.
comment:5 Changed 15 years ago by
Replying to guest:
[pete higgins]
bug: does not render in IE6, Opera, or Khtml ... as in "at all" ... IE complains with cryptic error, Khtml only shows tree, Opera shows tree without icons or focusing.
We aren't supporting opera or khtml, but of course it should work in IE.
comment:6 Changed 15 years ago by
comment:7 Changed 15 years ago by
bill:
I realize we're not "supporting" KHTML or Opera, but everything rendered 100% fine on those browsers in my earlier 3 pane test page. There are some issues in widgets it didn't exercise which prevent this new test page from working. Regarding IE, this is the issue that was preventing things from rendering: http://trac.dojotoolkit.org/ticket/3073. It renders fine now.
comment:9 Changed 15 years ago by
Replying to alex:
should we move this file to dijit/tests ?
yes? maybe even /dijits/tests/themeTester/tester.html allowing any external files and whatnot in the same folder [for read-ability]. Then, people can modify their own related smoketests [form widgets, io stuff, etc, etc] I've started doing this already locally [paths and whatnot], and included a basic theme-switching mechanism [query string] ...
[peter higgins]
comment:10 Changed 15 years ago by
I guess I don't care if the file is in dijits/tests. I'd rather leave the name as "themeTester.html" so that it's clear what it's for. I'm a bit concerned by this file getting co-opted into other purposes and losing it's 'quick look at a theme, loads fast' characteristics now.
Changed 15 years ago by
Attachment: | themeTester.diff added |
---|
newest addition, cleanup, more options, stuff moved, etc.
comment:12 Changed 15 years ago by
comment:13 Changed 15 years ago by
Changed 15 years ago by
Attachment: | themeTester.patch added |
---|
[phiggins][cla] update themeTester to include 'noir' and 'Dialog' widget
comment:15 Changed 15 years ago by
(In [9121]) Use LayoutContainer? so that widgets take up all the viewport space (except for the room needed on top, for the title). Refs #3069.
comment:16 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
closing this. themeTester is there. Dijit devs should new dijits to both "dijit-all.js" and include somewhere in themeTester.html a few tests to show various states available for theming. or tell me to, and I will.
(In [8662]) refs #3069: Updating theme tester