Opened 12 years ago

Closed 12 years ago

#3069 closed task (fixed)

Make theme tester page

Reported by: owen Owned by: owen
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Make a page for one-stop-shopping of testing your theme. Currently checked in as: /dijit/themes/themeTester.html .

Attachments (2)

themeTester.diff (19.5 KB) - added by guest 12 years ago.
newest addition, cleanup, more options, stuff moved, etc.
themeTester.patch (2.3 KB) - added by guest 12 years ago.
[phiggins][cla] update themeTester to include 'noir' and 'Dialog' widget

Download all attachments as: .zip

Change History (18)

comment:1 Changed 12 years ago by owen

(In [8662]) refs #3069: Updating theme tester

comment:2 Changed 12 years ago by alex

(In [8664]) if you declare an HTML DTD, you can't use XML. Fixing indendtation. Refs #3069

comment:3 Changed 12 years ago by alex

(In [8665]) reducing the number of 404's. Move data source generation to markup. Refs #3069

comment:4 Changed 12 years ago by guest

[pete higgins]

bug: does not render in IE6, Opera, or Khtml ... as in "at all" ... IE complains with cryptic error, Khtml only shows tree, Opera shows tree without icons or focusing.

comment:5 in reply to:  4 Changed 12 years ago by bill

Replying to guest:

[pete higgins]

bug: does not render in IE6, Opera, or Khtml ... as in "at all" ... IE complains with cryptic error, Khtml only shows tree, Opera shows tree without icons or focusing.

We aren't supporting opera or khtml, but of course it should work in IE.

comment:6 Changed 12 years ago by owen

(In [8673]) refs #3069 Latest version of theme tester (from Pete Higgins)

comment:7 Changed 12 years ago by alex

bill:

I realize we're not "supporting" KHTML or Opera, but everything rendered 100% fine on those browsers in my earlier 3 pane test page. There are some issues in widgets it didn't exercise which prevent this new test page from working. Regarding IE, this is the issue that was preventing things from rendering: http://trac.dojotoolkit.org/ticket/3073. It renders fine now.

comment:8 Changed 12 years ago by alex

should we move this file to dijit/tests ?

comment:9 in reply to:  8 Changed 12 years ago by guest

Replying to alex:

should we move this file to dijit/tests ?

yes? maybe even /dijits/tests/themeTester/tester.html allowing any external files and whatnot in the same folder [for read-ability]. Then, people can modify their own related smoketests [form widgets, io stuff, etc, etc] I've started doing this already locally [paths and whatnot], and included a basic theme-switching mechanism [query string] ...

[peter higgins]

comment:10 Changed 12 years ago by owen

I guess I don't care if the file is in dijits/tests. I'd rather leave the name as "themeTester.html" so that it's clear what it's for. I'm a bit concerned by this file getting co-opted into other purposes and losing it's 'quick look at a theme, loads fast' characteristics now.

comment:11 Changed 12 years ago by owen

Alex, feel free to move if you want.

Changed 12 years ago by guest

Attachment: themeTester.diff added

newest addition, cleanup, more options, stuff moved, etc.

comment:12 Changed 12 years ago by owen

(In [8750]) refs #3069 Checking in changes to theme teser for Pete Higgins. Will move to dijit/tests at a later date.

comment:13 Changed 12 years ago by owen

(In [8751]) refs #3069 Oops! Acccidentally checked in some half-baked css files -- reverting to what was there before

comment:14 Changed 12 years ago by bill

(In [8793]) Fix typo that was really confusing IE. Refs #3069.

Changed 12 years ago by guest

Attachment: themeTester.patch added

[phiggins][cla] update themeTester to include 'noir' and 'Dialog' widget

comment:15 Changed 12 years ago by bill

(In [9121]) Use LayoutContainer? so that widgets take up all the viewport space (except for the room needed on top, for the title). Refs #3069.

comment:16 Changed 12 years ago by dante

Resolution: fixed
Status: newclosed

closing this. themeTester is there. Dijit devs should new dijits to both "dijit-all.js" and include somewhere in themeTester.html a few tests to show various states available for theming. or tell me to, and I will.

Note: See TracTickets for help on using tickets.