Opened 12 years ago

Closed 12 years ago

#3035 closed defect (fixed)

validate test tooltip assumes en-us conventions

Reported by: Adam Peller Owned by: Douglas Hays
Priority: high Milestone: 0.9
Component: Internationalization Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

tooltip should not give $12,000.00 as an example. If it's going to use a currency, it should use dojo.currency.format to construct the string.

Change History (5)

comment:1 Changed 12 years ago by bill

Hi guys. Sorry, I just don't see this as a dojo issue. When I display test_validate.html on my Japanese machine, there are three issues:

  1. currency format is wrong
  2. tooltip is in english, not japanese
  3. surrounding boilerplate text is in english, not japanese

#2 and #3 can only realistically be solved by the server (which has one index.html page per locale), so we might as well have the server solve #1 too. It's possible that there will be some international sites that won't want to translate their text (but still want to translate the currency example), but I just don't want to worry about dojo supporting them. It doesn't seem worth our time at this point.

comment:2 Changed 12 years ago by Adam Peller

Ok, while I think they're orthogonal to some extent, it's fair to say both can be solved on the server.

Doug, if that's the ruling, then the fix would have to be to make the tests neutral somehow. In this case, it would mean taking away the example, unless we want to reconsider some sort of 'hinting' UI -- again, probably more complexity that we don't need.

comment:3 Changed 12 years ago by Douglas Hays

Resolution: wontfix
Status: newclosed

Seems to be a wontfix according to bill.

comment:4 Changed 12 years ago by Adam Peller

Resolution: wontfix
Status: closedreopened

ok, please read my comments and the original description of the bug.

Unit tests serve as examples. We can't have unit tests which are broken on other users' machines.

comment:5 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

(In [8696]) Fixes #3035. For the 1st currency example, the hardcoded amount in the message was removed. For the 2nd currency example, the message was programmatically created to show the correctly formmatted currency. Changing the locale to de-de from en-us seems to cause problems though.

Note: See TracTickets for help on using tickets.