Opened 13 years ago

Closed 12 years ago

Last modified 10 years ago

#3033 closed defect (fixed)

djConfig.locale doesn't work

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 0.9beta
Component: Core Version: 0.4.2
Keywords: Cc: alex
Blocked By: Blocking:

Description

djConfig used to get mixed in? It looks like I have to manually set dojo.locale=djConfig.locale now.

Attachments (1)

hostenv.patch (1.4 KB) - added by Adam Peller 13 years ago.
use djConfig.locale override, also fix _isDocumentOk() method

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by Adam Peller

Attachment: hostenv.patch added

use djConfig.locale override, also fix _isDocumentOk() method

comment:1 Changed 13 years ago by Adam Peller

Cc: alex added

Alex, can you look over this patch?

1) I thought we used to mixin djConfig, but I guess we have to explicitly carry over properties now, which is probably a good thing

2) the _isDocumentOk function looks suspicious. It's doing undefined comparisons on a var (will never work? not sure how that case would ever even happen?) I put in an
0 instead and shortened the code. Really belongs in its own ticket, I suppose?

comment:2 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

(In [8652]) merging a (great) patch from peller. Fixes #3033

Note: See TracTickets for help on using tickets.