Opened 12 years ago

Closed 12 years ago

#2996 closed defect (fixed)

rhino based command line unit tests with do not working

Reported by: James Burke Owned by: alex
Priority: high Milestone: 0.9beta
Component: TestFramework Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

After DOH was moved out to util, the command line tests do not seem to run in Rhino. Probably also an issue for Spidermonkey.

Attachments (2)

dojo.patch (383 bytes) - added by guest 12 years ago.
util.patch (259 bytes) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by guest

Attached are patches to the dojo and util trunk that allow the unit tests to be run under rhino.

However, this doesn't activate the code in util/doh/runner.js between lines 837 - 878 which look like they are intended for operation under Rhino? That code looks like it might be stale code left over from an older version? Since its not used or needed it should probably be removed -- unless I am missing something, which certainly happens enough! :-)

Changed 12 years ago by guest

Attachment: dojo.patch added

Changed 12 years ago by guest

Attachment: util.patch added

comment:2 Changed 12 years ago by guest

Er, I thought I remembered that trac would ask me for an e-mail address at some point. The above comment and patches are from David Snopek (dsnopek@…). I have a CLA on file. Please feel free to contact me with any questions. I'm willing to test what ever solution is decided on.

comment:3 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

seems I can now do:

cd util/doh && java -jar ../ java -jar ../buildscripts/lib/custom_rhino.jar runner.js 

and the tests (mostly) pass. Marking fixed.

Note: See TracTickets for help on using tickets.