Opened 13 years ago

Closed 13 years ago

#2990 closed task (fixed)

[build] Firebug files should be copied when building dojo

Reported by: guest Owned by: James Burke
Priority: high Milestone: 0.9beta
Component: General Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

When building dojo, firebug files should be copied to /dojo/_base/firebug.

At least, if copyTests is true, as DOH is copied in that case (see ​changeset 8369), but cannot be run without them.


As of now (revision 8564), those files are neither copied, nor being bundled into dojo.js. Neither with profile=0.9, nor with profile=base.

I wonder, if any one bothered to run those DOH tests over built version of dojo? Or are you using some other build process besides invoking build.js as is described here (in chapter 10. of dojo 0.4 book )? As for me, I resorted to explicitly copying those files in my *.bat script.

Best regards,
Konstantin Kolinko

Change History (6)

comment:1 Changed 13 years ago by guest

Seeing the same problem here. isDebug is totally broken if you're using a build and don't have firebug installed.

comment:2 Changed 13 years ago by Ben Lowery

(In [8648]) refs #2990. temporary fix until james gets back and we can figure out what to do. currently breaking nightly builds

comment:3 Changed 13 years ago by James Burke

Milestone: → 0.9beta
Owner: changed from anonymous to James Burke

comment:4 Changed 13 years ago by James Burke

(In [8784]) Refs #2990. Moving firebug out of base, but keeping it private. Confirmed with Alex.

comment:5 Changed 13 years ago by James Burke

(In [8785]) Refs #2990. Updating firebug console references to the right place.

comment:6 Changed 13 years ago by James Burke

Resolution: → fixed
Status: new → closed

(In [8786]) Fixes #2990. Firebug console moved out of _base, so now we can delete _base in the build.

Note: See TracTickets for help on using tickets.