Opened 13 years ago

Closed 13 years ago

#2983 closed defect (fixed)

0.9: Inline Edit Box issue when manipulated programmatically.

Reported by: Jared Jurkiewicz Owned by: Douglas Hays
Priority: high Milestone:
Component: Widgets Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

In inline edit box, the save and cancel functions always expect an event to be passed (such as pressing save or cancel button). This causes issues if you try to programmatically call save and cancel based on other state in the page. So really, save and cancel should only call dojo.stopEvent() if there is actually an event, such as:

save: function(e){

summary: Callback when user presses "Save" button if (e){

dojo.stopEvent(e);

} this.editing = false; this._showText();

},

cancel: function(e){

summary: Callback when user presses "Cancel" button if (e){

dojo.stopEvent(e);

} this.editing = false; this._visualize();

},

And the widget can then be used programmatically again to trigger save/cancel.

Change History (1)

comment:1 Changed 13 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [8542]) Fixes #2983, #2984. Added summary comment to onClick and added a test for an event parameter in save and cancel.

Note: See TracTickets for help on using tickets.