Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#2978 closed defect (fixed)

make Dijit test pages all use consistent CSS and idiomatic JS

Reported by: alex Owned by: dante
Priority: high Milestone: 0.9beta
Component: Dijit Version: 0.9
Keywords: Cc: alex, Adam Peller, koranteng, bill
Blocked By: Blocking:

Description

people learn Dojo from our examples, which means they need to be "clean", even if they're just smoke-tests. The markup and the code needs to conform to basic standards of readability and idiomaticness.

Attachments (3)

dijit.tests.patches​ (8.9 KB) - added by guest 12 years ago.
dijit.tests.patch​ (40.6 KB) - added by dante 12 years ago.
newest set #3
quick.tests.patch​ (6.5 KB) - added by dante 12 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 12 years ago by alex

(In [8537]) making more of the test pages look less like ass. Refs #2978

comment:2 Changed 12 years ago by alex

(In [8538]) make the test page look consistent. Refs #2978

comment:3 Changed 12 years ago by alex

(In [8539]) refs #2978

comment:4 Changed 12 years ago by bill

Milestone: 0.9M2 → 0.9beta
Owner: changed from bill to itorrey
Version: 0.4.2 → 0.9

comment:5 Changed 12 years ago by bill

Component: Widgets → Dijit

comment:6 Changed 12 years ago by alex

Summary: make Dijit test pages all use consistent CSS and idomatic JS → make Dijit test pages all use consistent CSS and idiomatic JS

comment:7 Changed 12 years ago by alex

(In [8816]) updating to use the new test page CSS file. Refs #2978

Changed 12 years ago by guest

Attachment: dijit.tests.patches​ added

comment:8 Changed 12 years ago by guest

patch by Pete Higgins [cla] to unify look/feel ... first pass. Syntax cleanup and indenting next.

Added programmatic Dialog Creation and [breaking] href="" Dialog to test_Dialog.html [will file separate ticket for href] ...

suggest all dijit test pages include [working] example of programmatic creation as well.

comment:9 Changed 12 years ago by bill

Owner: changed from itorrey to phiggins

Thanks for the patch! Checking in now. Will leave bug open for your future fixes (as you mentioned above).

comment:10 Changed 12 years ago by bill

(In [9053]) Patch by Pete Higgins [cla on file] to unify look/feel ... first pass. Syntax cleanup and indenting next.

Added programmatic Dialog Creation and [breaking] href="" Dialog to test_Dialog.html [bug #3373] ...

Suggest all dijit test pages include [working] example of programmatic creation as well.

Refs #2978

comment:11 Changed 12 years ago by dante

Owner: changed from phiggins to dante

comment:12 Changed 12 years ago by bill

(In [9096]) Make Dijit test pages all use consistent CSS and idiomatic JS (not finished yet but here's a big chunk of files) Patch from Pete Higgins (CLA on file). Refs #2978.

Changed 12 years ago by dante

Attachment: dijit.tests.patch​ added

newest set #3

comment:13 Changed 12 years ago by dante

new patch added almost finishes up doctype consistency, closes dijit.util.parser references, and indention/markup.

after commit, will do a 'final cleanup' and close ticket.

comment:14 Changed 12 years ago by bill

(In [9170]) More test file updates from Pete Higgins (CLA on file). Refs #2978

Changed 12 years ago by dante

Attachment: quick.tests.patch​ added

comment:15 Changed 12 years ago by dante

Resolution: → fixed
Status: new → closed

closing this. _most_ are done, tests changing rapidly atm. will keep on top of test consistency issue.

comment:16 Changed 12 years ago by dante

(In [12254]) refs #2978 - cleanup BorderContainer? tests

comment:17 Changed 9 years ago by bill

(In [22277]) fix programatic creation example, refs #2978 ([9053])

Note: See TracTickets for help on using tickets.