#2978 closed defect (fixed)
make Dijit test pages all use consistent CSS and idiomatic JS
Reported by: | alex | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 0.9beta |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | alex, Adam Peller, koranteng, bill | |
Blocked By: | Blocking: |
Description
people learn Dojo from our examples, which means they need to be "clean", even if they're just smoke-tests. The markup and the code needs to conform to basic standards of readability and idiomaticness.
Attachments (3)
Change History (20)
comment:1 Changed 14 years ago by
comment:4 Changed 14 years ago by
Milestone: | 0.9M2 → 0.9beta |
---|---|
Owner: | changed from bill to itorrey |
Version: | 0.4.2 → 0.9 |
comment:5 Changed 14 years ago by
Component: | Widgets → Dijit |
---|
comment:6 Changed 14 years ago by
Summary: | make Dijit test pages all use consistent CSS and idomatic JS → make Dijit test pages all use consistent CSS and idiomatic JS |
---|
comment:7 Changed 14 years ago by
Changed 14 years ago by
Attachment: | dijit.tests.patches added |
---|
comment:8 Changed 14 years ago by
patch by Pete Higgins [cla] to unify look/feel ... first pass. Syntax cleanup and indenting next.
Added programmatic Dialog Creation and [breaking] href="" Dialog to test_Dialog.html [will file separate ticket for href] ...
suggest all dijit test pages include [working] example of programmatic creation as well.
comment:9 Changed 14 years ago by
Owner: | changed from itorrey to phiggins |
---|
Thanks for the patch! Checking in now. Will leave bug open for your future fixes (as you mentioned above).
comment:10 Changed 14 years ago by
(In [9053]) Patch by Pete Higgins [cla on file] to unify look/feel ... first pass. Syntax cleanup and indenting next.
Added programmatic Dialog Creation and [breaking] href="" Dialog to test_Dialog.html [bug #3373] ...
Suggest all dijit test pages include [working] example of programmatic creation as well.
Refs #2978
comment:11 Changed 14 years ago by
Owner: | changed from phiggins to dante |
---|
comment:12 Changed 14 years ago by
comment:13 Changed 14 years ago by
new patch added almost finishes up doctype consistency, closes dijit.util.parser references, and indention/markup.
after commit, will do a 'final cleanup' and close ticket.
comment:14 Changed 14 years ago by
Changed 14 years ago by
Attachment: | quick.tests.patch added |
---|
comment:15 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
closing this. _most_ are done, tests changing rapidly atm. will keep on top of test consistency issue.
(In [8537]) making more of the test pages look less like ass. Refs #2978