Opened 12 years ago

Closed 12 years ago

#2957 closed task (fixed)

TooltipDialog: accessibility

Reported by: bill Owned by: Becky Gibson
Priority: high Milestone: 1.0
Component: Accessibility Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Becky Gibson)

Implement accessibility for TooltipDialog? (of course, this depends on TooltipDialog? being finished, which in turn depends on Dialog being ported).

Attachments (1)

tooltipdlg_a11y.diff​ (4.7 KB) - added by Becky Gibson 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by Becky Gibson

Milestone: 0.9beta → 1.0
Status: new → assigned

Moved from 0.9 beta since code isn't checked in yet.

Changed 12 years ago by Becky Gibson

Attachment: tooltipdlg_a11y.diff​ added

comment:2 Changed 12 years ago by Becky Gibson

Description: modified (diff)

patch for proposed a11y implementation (http://dojotoolkit.org/forum/tooltip-and-tooltip-dialog#comment-3041) attached. Works in Firefox - has issues in IE when first focus the tooltip dialog and press shift-tab. Just meant to demonstrate the proposal-will need a bit more work.

comment:3 Changed 12 years ago by Becky Gibson

Description: modified (diff)

patch for proposed a11y implementation (http://dojotoolkit.org/forum/tooltip-and-tooltip-dialog#comment-3041) attached. Works in Firefox - has issues in IE when first focus the tooltip dialog and press shift-tab. Just meant to demonstrate the proposal-will need a bit more work.

(fix previous overwrite of description - what a dummy!)

comment:4 Changed 12 years ago by Becky Gibson

Resolution: → fixed
Status: assigned → closed

(In [9334]) make tooltip dialog modal for keyboard usage - user can't tab or shift-tab focus out of dialog - must close with escape key. Duplication of code in tooltip dialog and dialog -will create a track ticket to consider refactoring fixes #2957

comment:5 Changed 12 years ago by bill

Resolution: fixed
Status: closed → reopened

Can we change it so focus goes to first item <input> in TooltipDialog?? That's more convenient for users, and also with the current code on FF, putting a dotted border around the tooltip looks pretty bad (aesthetically) to me.

comment:6 Changed 12 years ago by bill

PS: if it's not possible to focus on the first <input> (because we need to focus on a node with a waiRole=Dialog, or something like that), then at least we should probably use a DOM node that falls inside the (curved) TooltipDialog? border. I think that would look better anyway.

comment:7 Changed 12 years ago by Becky Gibson

There is no guarantee that a tooltip dialog will have a focusable item. I also didn't want to expend the code to try to find the first focusable item. By setting the focus to the dialog itself the screen reader user will know that focus has changed to the dialog and if the developer has provided a dialog title it will be spoken. I can make an inner element to set focus to so it will look better.

comment:8 Changed 12 years ago by bill

OK. But also keep in mind the changes from #3580 to see if that changes anything.

comment:9 Changed 12 years ago by Becky Gibson

Resolution: → fixed
Status: reopened → closed

(In [9732]) fixes #2957 - added an inner div to set focus onto so focus rectangle does not overlap with outer dialog border and arrow.

Note: See TracTickets for help on using tickets.