Opened 12 years ago

Closed 12 years ago

#2949 closed task (fixed)

SplitContainer: code review / cleanup

Reported by: bill Owned by: Adam Peller
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

The Splitcontainer code seems too complex in it's calculations; need a general review/cleanup.

Change History (13)

comment:1 Changed 12 years ago by Adam Peller

Component: Widgets → Dijit

comment:2 Changed 12 years ago by Adam Peller

(In [9466]) General cleanup. Refs #2949

comment:3 Changed 12 years ago by Adam Peller

(In [9467]) revert [9466]. Refs #2949

comment:4 Changed 12 years ago by Adam Peller

(In [9468]) General cleanup. Refs #2949

comment:5 Changed 12 years ago by Adam Peller

(In [9469]) General cleanup. Refs #2949

comment:6 Changed 12 years ago by Adam Peller

(In [9470]) General cleanup. Refs #2949

comment:7 Changed 12 years ago by Adam Peller

(In [9471]) General cleanup. Refs #2949

comment:8 Changed 12 years ago by Adam Peller

(In [9472]) General cleanup. Refs #2949

comment:9 Changed 12 years ago by Adam Peller

(In [9473]) General cleanup. Refs #2949

comment:10 Changed 12 years ago by bill

Owner: changed from koranteng to Adam Peller

comment:11 Changed 12 years ago by Adam Peller

(In [9545]) more for loops. Refs #2949

comment:12 Changed 12 years ago by Adam Peller

Milestone: 0.9 → 1.0

Did all the trivial cleanup to make the code look better, but it's probably destined for a rewrite in 1.0. Leaving this open.

comment:13 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

done making passes through existing code. rewrite will be considered in #4117

Note: See TracTickets for help on using tickets.