Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#2920 closed defect (fixed)

Building default module prefix paths if messed up

Reported by: James Burke Owned by: James Burke
Priority: high Milestone:
Component: BuildSystem Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

This code in buildUtil.evalProfile is messed up:

    for(var i = 0; i < usedPrefixes.length; i++){
        if(!buildUtil.isValueInArray(usedPrefixes[i], dependencies.prefixes)){
            dependencies.prefixes.push([usedPrefixes[i], "../../" + usedPrefixes[i]]);
        }
    }

The dependencies.prefixes array is an array of arrays, so that isValueInArray thing never works.

Also, the "../../" assumption is wrong. The path should be relative to dojo and not to util/buildscripts. (Dojo's path needs to be relative to util/buildscripts, but we can hide that inside the build files).

Thanks to Ben Lowery for pointing this out.

Change History (2)

comment:1 Changed 13 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [8415]) Fixes #2920. Holy cow did I mess up detecting and building default prefix paths. This revision fixes that as well as allows absolute paths for prefixes.

comment:2 Changed 12 years ago by (none)

Milestone: 0.9M2

Milestone 0.9M2 deleted

Note: See TracTickets for help on using tickets.