#2920 closed defect (fixed)
Building default module prefix paths if messed up
Reported by: | James Burke | Owned by: | James Burke |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | BuildSystem | Version: | 0.4.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
This code in buildUtil.evalProfile is messed up:
for(var i = 0; i < usedPrefixes.length; i++){ if(!buildUtil.isValueInArray(usedPrefixes[i], dependencies.prefixes)){ dependencies.prefixes.push([usedPrefixes[i], "../../" + usedPrefixes[i]]); } }
The dependencies.prefixes array is an array of arrays, so that isValueInArray thing never works.
Also, the "../../" assumption is wrong. The path should be relative to dojo and not to util/buildscripts. (Dojo's path needs to be relative to util/buildscripts, but we can hide that inside the build files).
Thanks to Ben Lowery for pointing this out.
Note: See
TracTickets for help on using
tickets.
(In [8415]) Fixes #2920. Holy cow did I mess up detecting and building default prefix paths. This revision fixes that as well as allows absolute paths for prefixes.