Opened 12 years ago

Closed 12 years ago

#2910 closed defect (fixed)

ScriptSrcTransport: _finish method has bad assumption about event.response

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 0.9
Component: IO Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

In the _finish() method, this line is problematic:

var response = event ? event.response : null;

This event.response check is only valid for DSR-type requests. For jsonp type requests, this event introspection should not be done. If the jsonp callback data has a response property, bad things could happen (wrong data returned to the jsonp callback).

Change History (1)

comment:1 Changed 12 years ago by James Burke

Milestone: 0.4.40.9
Resolution: fixed
Status: newclosed

This was fixed in 0.9, and I'm not going to change this for 0.4 since it would be a change in behavior, and would break existing implementations.

Note: See TracTickets for help on using tickets.