Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2844 closed defect (fixed)

Formbind bug in IE6: html input field named action

Reported by: guest Owned by: Jared Jurkiewicz
Priority: high Milestone:
Component: IO Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

Hi there, I hope, this hasn't been reported before:

Formbind has a problem with form elements having an ID or name called "action", e.g.

<input type="hidden" id="action" name="action" value="acquire_post">

Submitting this form via Formbind works fine with Firefox but does not on IE6. After onSubmit returns true, I receive the output below. I couldn't believe it myself, but renaming that field to my_action solved the problem.

Debug Output: [TypeError: Object doesn't support this property or method] when calling submit$joinpoint$method on [object Object] with arguments [object Object] FATAL exception raised: Object doesn't support this property or method"

Thanks! Dirk

Attachments (5)

dojo_0.4.3_formbind_bug.patch (2.4 KB) - added by Jared Jurkiewicz 12 years ago.
dojoform.html (3.4 KB) - added by Jared Jurkiewicz 12 years ago.
dojo.io.FormBind_0.4.X_20070723.patch (6.3 KB) - added by Jared Jurkiewicz 12 years ago.
dojo.io.IFrameIO_20070724.patch (1.5 KB) - added by Jared Jurkiewicz 12 years ago.
dojo_0.9_xhrForm_20070724.patch (3.4 KB) - added by Jared Jurkiewicz 12 years ago.
Patch to 0.9 + UT for form handling issue.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 12 years ago by Jared Jurkiewicz

This problem was also hit by a co-worker of mine. It occurs in IE on calls that do:

kwArgs.formNode.getAttribute("action");

In the IO code for Browser, scriptsrc, and IFrame. The fix is also pretty darn simple. I'll be attaching a testcase, plus patch, for 0.4.X to this bug. 0.9 should also be checked out for issues as I suspect it also likely has them in the _base/xhr.js code.

Note I'm under CLA through my company so the patch is safe. :-)

Changed 12 years ago by Jared Jurkiewicz

Changed 12 years ago by Jared Jurkiewicz

Attachment: dojoform.html added

Changed 12 years ago by Jared Jurkiewicz

comment:2 Changed 12 years ago by Jared Jurkiewicz

(In [9756]) Putting in a patch for #2844 handling of node.getAttribute() on IE. refs #2844

comment:3 Changed 12 years ago by Jared Jurkiewicz

Owner: changed from alex to Jared Jurkiewicz

comment:4 Changed 12 years ago by Jared Jurkiewicz

The above for 0.4.X was tested on:

Firefox 2.0.0.5 Firefox 1.5.0.12 IE 6.0 IE 7.0 Safari B3 Opera 9.2 Seamonkey 1.1.2 Mozilla 1.7.13

Next to work on is to verify if 0.9 has similar issues, and patch them if so.

comment:5 Changed 12 years ago by Jared Jurkiewicz

Follow on patch needed for IFrameIO. More experiments revealed it needs to do setting via the returned nodes as well. so ... this gets a bit uglier for IFrameIO. *sigh*. Patch will be attached shortly.

Changed 12 years ago by Jared Jurkiewicz

comment:6 Changed 12 years ago by Jared Jurkiewicz

(In [9771]) Followon patch to deal with IE issues and form attributes. refs #2844

Changed 12 years ago by Jared Jurkiewicz

Patch to 0.9 + UT for form handling issue.

comment:7 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [9776]) Patch to 0.9 for form handling issue. fixes #2844

comment:8 Changed 12 years ago by Jared Jurkiewicz

Tested for 0.4.X on: Firefox 2.0.0.5 Safari B3 IE 6 Seamonkey 1.1.2 Opera 9.2

Tested for 0.9 on: IE 6 Safari B3 Forefox 2.0.0.5 Opera 9.2 Seamonkey 1.1.2

Note: See TracTickets for help on using tickets.