Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2821 closed task (fixed)

support widgetsInTemplate (nested widgets in a template)

Reported by: bill Owned by: liucougar
Priority: high Milestone: 0.9beta
Component: Widgets Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Allow widget templates to have dojoType="..." which create widgets recursively. I guess this would be a mixin that extends TemplatedWidget?, maybe called TemplatedSuperWidget? :-)

Prerequisite for porting editor.

This was a 0.4 feature but has to be rewritten to work in dijit.

Attachments (4)

2821.patch (4.6 KB) - added by liucougar 12 years ago.
core support
2821_test.patch (6.2 KB) - added by liucougar 12 years ago.
unit test package for dijit which includes widgetsInTemplate test
2821_dojo.patch (661 bytes) - added by liucougar 12 years ago.
patch for event.js
2821-general-dijit-breakage.patch (9.5 KB) - added by koranteng 12 years ago.
fixes repercussion of event changes in dijit

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by liucougar

Status: newassigned

the attached patch adds this feature to dijit.base.TemplatedWidget?, as there are only 10 lines in the code to handle widgetsInTemplate, so I did not make it into another mixin on top of TemplatedWidget?

now dijit.util.parser is always required in TemplatedWidget?. this is not ideal, need to find a way to load this optionally

Changed 12 years ago by liucougar

Attachment: 2821.patch added

core support

Changed 12 years ago by liucougar

Attachment: 2821_test.patch added

unit test package for dijit which includes widgetsInTemplate test

Changed 12 years ago by liucougar

Attachment: 2821_dojo.patch added

patch for event.js

comment:2 Changed 12 years ago by liucougar

Resolution: fixed
Status: assignedclosed

(In [8503]) fixes #2821 and #1733 Now all domevent names in template should be in its original case (onClick on a domnode does not work any more, you have to use onclick:onClick in dojoAttachEvent for this case) D.O.H module for dijit

Changed 12 years ago by koranteng

fixes repercussion of event changes in dijit

comment:3 Changed 12 years ago by Adam Peller

(In [8509]) Koranteng to the rescue. Fix regressions from recent check-ins. Refs #2821.

comment:4 Changed 12 years ago by liucougar

(In [8522]) refs #2821 : fixed test regresion introduced in r8509

comment:5 Changed 12 years ago by liucougar

(In [8525]) refs #2821 : expected and actual is inverted, fixed

comment:6 Changed 12 years ago by bill

(In [9185]) remove TODO that's been done; refs #2821.

Note: See TracTickets for help on using tickets.