Opened 12 years ago
Closed 12 years ago
#2804 closed task (fixed)
restore commonly used dojo.dom/dojo.style functions
| Reported by: | bill | Owned by: | alex |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9beta |
| Component: | HTML | Version: | 0.9 |
| Keywords: | 4dijit | Cc: | |
| Blocked By: | Blocking: |
Description (last modified by )
The dijit port to dojo uncovered a bunch of deleted dojo functions that dijit is using; see http://dojotoolkit.org/developer/dijit/notes/port09
Anyway, from the meeting today, I think the consensus was to restore addClass()/removeClass()/hasClass() (using Scott's implementation), and disableSelection(), destroyNode(), and isAncestor()
PS: after adding these functions in, dijit needs to be changed to use them, so either do that or pass the bug over to me. Thanks!
Change History (11)
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 12 years ago by
| Owner: | changed from alex to bill |
|---|
comment:3 Changed 12 years ago by
The functions I committed are only the xxxClass functions (in _base/html.js).
comment:4 Changed 12 years ago by
comment:5 Changed 12 years ago by
comment:6 Changed 12 years ago by
| Owner: | changed from bill to alex |
|---|
OK, still need to add in disableSelection(), destroyNode(), and isAncestor().
comment:7 Changed 12 years ago by
| Component: | DOM → HTML |
|---|
comment:8 Changed 12 years ago by
| Keywords: | 4dijit added |
|---|
comment:9 Changed 12 years ago by
dojo._destroyElement() added (see #2931). Remaining are just isAncestor() and disableSelection() (or setSelection(boolean))
comment:11 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I inadvertently committed versions of these functions in r8402. I intended to commit them, but not in that revision. Anyway, they are there now.