Opened 13 years ago

Closed 12 years ago

#2804 closed task (fixed)

restore commonly used dojo.dom/dojo.style functions

Reported by: bill Owned by: alex
Priority: high Milestone: 0.9beta
Component: HTML Version: 0.9
Keywords: 4dijit Cc:
Blocked By: Blocking:

Description (last modified by bill)

The dijit port to dojo uncovered a bunch of deleted dojo functions that dijit is using; see http://dojotoolkit.org/developer/dijit/notes/port09

Anyway, from the meeting today, I think the consensus was to restore addClass()/removeClass()/hasClass() (using Scott's implementation), and disableSelection(), destroyNode(), and isAncestor()

PS: after adding these functions in, dijit needs to be changed to use them, so either do that or pass the bug over to me. Thanks!

Change History (11)

comment:1 Changed 13 years ago by bill

Description: modified (diff)

comment:2 Changed 13 years ago by sjmiles

Owner: changed from alex to bill

I inadvertently committed versions of these functions in r8402. I intended to commit them, but not in that revision. Anyway, they are there now.

comment:3 Changed 13 years ago by sjmiles

The functions I committed are only the xxxClass functions (in _base/html.js).

comment:4 Changed 13 years ago by bill

(In [8412]) Fix typo in previous checkin to this file. Refs #2804.

comment:5 Changed 13 years ago by bill

(In [8413]) Use dojo.addClass()/removeClass(), now that they have been added back into dojo. Refs #2804.

comment:6 Changed 13 years ago by bill

Owner: changed from bill to alex

OK, still need to add in disableSelection(), destroyNode(), and isAncestor().

comment:7 Changed 13 years ago by bill

Component: DOMHTML

comment:8 Changed 12 years ago by bill

Keywords: 4dijit added

comment:9 Changed 12 years ago by bill

dojo._destroyElement() added (see #2931). Remaining are just isAncestor() and disableSelection() (or setSelection(boolean))

comment:10 Changed 12 years ago by alex

(In [9435]) move Dijit to dojo.setSelectable(). Refs #2804

comment:11 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

(In [9436]) removing custom ancestor finding functions in favor of dojo.isDescendant(). Fixes #2804

Note: See TracTickets for help on using tickets.