Opened 12 years ago

Closed 12 years ago

#2792 closed defect (fixed)

dojo.io.bind: XMLHTTPTransport eats errors with evaling json response

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 0.9
Component: IO Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

In BrowserIO.js, around line 287 (for the 0.4 branch code), there is a try/catch block around evaling the response to make a json object. The catch code prints some debug messages and then keeps going, calling the load callback. It should call the error callback instead.

Change History (6)

comment:1 Changed 12 years ago by alex

Milestone: 0.4.3

comment:2 Changed 12 years ago by James Burke

Owner: changed from alex to James Burke

comment:3 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [8513]) Fixes #2792: malformed json eval error was not sent to error callback.

comment:4 Changed 12 years ago by James Burke

Resolution: fixed

(In [8514]) Reverting change that fixes #2792. Decided to hold off since it might introduce some unwanted behavioral changes.

comment:5 Changed 12 years ago by James Burke

Resolution: fixed
Status: closedreopened

comment:6 Changed 12 years ago by James Burke

Milestone: 0.4.40.9
Resolution: fixed
Status: reopenedclosed

Fixed in 0.9, not likely to revisit for 0.4 branch, since it is a behavior change.

Note: See TracTickets for help on using tickets.