Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2784 closed defect (fixed)

onkey event broken in 0.4.2 (due to change [7508])

Reported by: bill Owned by: alex
Priority: high Milestone:
Component: Events Version: 0.4.2
Keywords: Cc:
Blocked by: Blocking:

Description

After [7508], keyboard handling (navigation via arrow keys) for the menu doesn't work (tested on FF2.0 but may be true for other browsers too). See http://download.dojotoolkit.org/release-0.4.2/dojo-0.4.2-widget/tests/widget/test_Menu2.html
The onKey event doesn't seem to fire anymore, apparently due to this code being commented out:

[event/common.js]
   277			}else{
   278				var ao = interpolateArgs(arguments, true);
   279			}
   280			/*
   281			if(dojo.lang.isString(ao.srcFunc) && (ao.srcFunc.toLowerCase() == "onkey") ){
   282				if(dojo.render.html.ie){
   283					ao.srcFunc = "onkeydown";
   284					this.connect(ao);
   285				}
   286				ao.srcFunc = "onkeypress";
   287			}
   288			*/
   289	
   290			if(dojo.lang.isArray(ao.srcObj) && ao.srcObj!=""){
   291				var tmpAO = {};

Please be careful when making changes on the branches; the branch should only get critical bug fixes because "efficiency improvements" like this can (and did) break something important.

Change History (2)

comment:1 Changed 7 years ago by jburke

  • Resolution set to fixed
  • Status changed from new to closed

(In [8599]) Fixes #2784. Matches event.connect to old trunk.

comment:2 Changed 7 years ago by anonymous

  • Milestone 0.4.3 deleted

Milestone 0.4.3 deleted

Note: See TracTickets for help on using tickets.