Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#277 closed defect (fixed)

FloatingPane+descendants doesnt work in khtml

Reported by: fredrik j at bredband net Owned by: alex
Priority: high Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

When the floatingpane is created, it creates a new LayoutPane? automatically. in LayoutPane?'s postCreate there is a call to:

this.isVisible()

When we are calling this we eventually end up in

dojo.style.getComputedStyle()

obviously to find out if the computed style of our node.

The only problem is that the node is'nt appended to the dom yet as we just created the LayoutPane? from within FloatingPane?.

Gecko doesnt mind and returns a proper "empty" object, but khtml who is much more picky about dom faults returns null instead of an object. So when we try to call getPropertyValue on null object it bails out.

I managed to prevent it from bailing by doing a check if LayoutPanes? domNode is a desedant of the body node before doing a check if we are visible inside LayoutPane?'s postCreate.

Iam sure you will find a better way to get around this than I did.

Regards Fredrik Johansson

Change History (4)

comment:1 Changed 14 years ago by Dustin Machi

I updated style.js to avoid this crash issue. But I think some more needs to go into how to avoid this condition in the first place. postCreate and postInitialize should be deferred until after they become part of the document.

comment:2 Changed 14 years ago by alex

Owner: changed from anonymous to alex
Status: newassigned

Oddly, this now works correctly on Konqueror (KHTML), but not Safari 2.0.3. I'm still on it.

comment:3 Changed 14 years ago by anonymous

Resolution: fixed
Status: assignedclosed

fixed in rev [2814]

comment:4 Changed 13 years ago by (none)

Milestone: 0.2.2release

Milestone 0.2.2release deleted

Note: See TracTickets for help on using tickets.