#2766 closed defect (fixed)
Filter out dojo.require() calls with variables instead of strings
| Reported by: | James Burke | Owned by: | Rawld Gill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | Loader | Version: | 0.4.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Right now the xd loader, and probably the build system and debug modules pick up dojo.require/requireIf calls that have a variable for the resource name. This usually results in a bad error. Skip those things, since they are meant to be dynamic calls anyway.
Change History (12)
comment:1 Changed 15 years ago by
| Milestone: | 0.9beta → 0.9 |
|---|
comment:2 Changed 14 years ago by
| Milestone: | 0.9 → 1.0 |
|---|
comment:3 Changed 14 years ago by
| Milestone: | 1.0 → 1.1 |
|---|
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 Changed 14 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:6 Changed 14 years ago by
| Milestone: | 1.1 → 1.2 |
|---|
comment:7 Changed 14 years ago by
| Milestone: | 1.2 → future |
|---|
comment:8 Changed 11 years ago by
| Owner: | changed from James Burke to Rawld Gill |
|---|
not sure if these tickets are even valid anymore but assigning to rawld to check
comment:9 Changed 11 years ago by
| Status: | reopened → new |
|---|
comment:10 Changed 11 years ago by
| Status: | new → assigned |
|---|
comment:11 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The version 1.7+ builder processes dojo.require, dojo.provide, dojo.platformRequire,and dojo.requireLocalization with constant string args only. It ignores dojo.requireIf and dojo.requireAfterIf. This will not be enhanced.
The version 1.7+ loader processes any expression inside any of dojo.require/provide/platformRequire/requireLocatization/requireIf/requireAfterIf when converting a not-xdomain, not-AMD module during xdomain loading.
If you need more, convert to AMD modules and use/write a plugin.
comment:12 Changed 11 years ago by
| Milestone: | future → 1.7 |
|---|
Moving to 0.9 final. This has not been a common complaint with the 0.4.x system.