Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#2766 closed defect (fixed)

Filter out dojo.require() calls with variables instead of strings

Reported by: James Burke Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Loader Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

Right now the xd loader, and probably the build system and debug modules pick up dojo.require/requireIf calls that have a variable for the resource name. This usually results in a bad error. Skip those things, since they are meant to be dynamic calls anyway.

Change History (12)

comment:1 Changed 12 years ago by James Burke

Milestone: 0.9beta0.9

Moving to 0.9 final. This has not been a common complaint with the 0.4.x system.

comment:2 Changed 12 years ago by James Burke

Milestone: 0.91.0

comment:3 Changed 12 years ago by James Burke

Milestone: 1.01.1

comment:4 Changed 11 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [12268]) Fixes #2766: restore debugAtAllCosts for xdomain cases.

comment:5 Changed 11 years ago by James Burke

Resolution: fixed
Status: closedreopened

oops, wrong ticket in the commit message: r12268 fixes #5223, not this bug.

comment:6 Changed 11 years ago by James Burke

Milestone: 1.11.2

comment:7 Changed 11 years ago by James Burke

Milestone: 1.2future

comment:8 Changed 8 years ago by bill

Owner: changed from James Burke to Rawld Gill

not sure if these tickets are even valid anymore but assigning to rawld to check

comment:9 Changed 8 years ago by Rawld Gill

Status: reopenednew

comment:10 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:11 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

The version 1.7+ builder processes dojo.require, dojo.provide, dojo.platformRequire,and dojo.requireLocalization with constant string args only. It ignores dojo.requireIf and dojo.requireAfterIf. This will not be enhanced.

The version 1.7+ loader processes any expression inside any of dojo.require/provide/platformRequire/requireLocatization/requireIf/requireAfterIf when converting a not-xdomain, not-AMD module during xdomain loading.

If you need more, convert to AMD modules and use/write a plugin.

comment:12 Changed 8 years ago by bill

Milestone: future1.7
Note: See TracTickets for help on using tickets.