FilteringTable.columns[i].sortFunction - KISS, one-liner

[guest]

[ Dojo 0.4.2 ] I can deal with an dojoAddOnLoad like this:

var filteringTable     = dojo.widget.byId ('filteringTableId');
var myKradSortFunction = function (a, b, direction) { ... }
filteringTable.columns[0].sortFunction = myKradSortFunction;

It is not as elegant is it should be, but it is straight-forward. I really shouldn't have to walk into your house and raid the fridge when I want to borrow a cup of milk... For another day...

This allows me to build the FilteringTable? from markup, which vastly simplifies my life. CSS headaches, etc...

So if everyone else insists on making things more complicated then they {need to/should} be, here's a patch for the little guy.

--- FilteringTable.js.original  2007-04-13 13:09:44.000000000 -0400
+++ FilteringTable.js   2007-04-13 13:09:54.000000000 -0400
@@ -427,6 +427,7 @@
                        }
                        var a = self.store.getField(self.getDataByRow(rowA), field);
                        var b = self.store.getField(self.getDataByRow(rowB), field);
+                       if (meta.sortFunction && typeof meta.sortFunction == 'function') { return meta.sortFunction (a, b, dir); } /* PATCH */
                        var ret = 0;
                        if (a > b) {
                                ret = 1;

[Adam Peller]

Who submitted this? Is there a CLA?

[Adam Peller]

I guess this falls under the category of "trivial"

[Tom Trenka]

More like invalid, because I'm not going to add the ability to pass in a direction; that's already taken care of by the createSorter method's execution.

[(none)]

Milestone 0.4.4 deleted