Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2704 closed task (fixed)

Port dojo.data API and JsonItemStore to Dojo 0.9 M1 code split.

Reported by: guest Owned by: Adam Peller
Priority: high Milestone:
Component: Data Version: 0.9
Keywords: dojo.data Cc: peller@…
Blocked By: Blocking:

Description

Port dojo.data API and JsonItemStore? to Dojo 0.9 M1 code split.

This tracker is for porting of the 0.9 version of dojo.data to the M1 code split. In essense, it will contain all the API definition files Read.js, Write.js, Identity.js, Request.js, and Notification.js, the basic simple store JsonItemStore?, and the few common helper mixins and functions that can be shared across store implementations.

It may also include fixes for other tracker raised issues, which will be documented in this tracker as they are noted.

Attachments (1)

dojo.data_20070406.patch (109.4 KB) - added by guest 12 years ago.
Tentative patch file for the dojo data APIs + JsonItemStore? for 0.9 split.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by guest

Attachment: dojo.data_20070406.patch added

Tentative patch file for the dojo data APIs + JsonItemStore? for 0.9 split.

comment:1 Changed 12 years ago by guest

The patchfile dojo.data_20070406.patch is the latest pass at porting the base APIs for dojo.data to M1, plus the reference implementation for read of JsonItemStore?. The patch includes 45 unit tests that test the basic read functionality of JsonItemStore? as well as the common utility functions other stores may make use of.

In addition, this set of code should address the following trackers in trac.dojotoolkit.org :

#2541 (Calling fetch before getItemByIdentity() is now not necessary, it works as defined by the Read API).

#2543 (Sorting API through fetch and using soort object array is present in Read.js. Reference implementation is in JsonItemStore?)

#2544 (Paging API through fetch and using start/count is present in Read.js. Reference implementation is in JsonItemStore?)

#2545 (Callback names all match what was decided on in the meetings).

#2546 (Reading in a data set in JsonItemStore? that has collisions on 'unique' identifiers will cause an error to be thrown).

#2547 (The worst offending function I saw offhand was isItem(). It was O(n) in performance and was called a lot. I've converted it to being O(1) with minimal code change).

#2553 (I fixed the JsonItemStore? so it should be able to take an attribute 'item' as a parameter instead of just an attribute name string).

Sincerely,

-- Jared Jurkiewicz

comment:2 Changed 12 years ago by Adam Peller

Owner: changed from skinner to Adam Peller
Type: enhancementtask

comment:3 Changed 12 years ago by Adam Peller

(In [7966]) Refs #2704

comment:4 Changed 12 years ago by Adam Peller

(In [7968]) Refs #2704

comment:5 Changed 12 years ago by Adam Peller

(In [7969]) Not thrilled with asserts - will revisit later. Also, still need to port io/xhrGet code when ready. Refs #2704

comment:6 Changed 12 years ago by Adam Peller

(In [7971]) Refs #2704

comment:7 Changed 12 years ago by Adam Peller

(In [7972]) Refs #2704

comment:8 Changed 12 years ago by Adam Peller

(In [7973]) Refs #2704

comment:9 Changed 12 years ago by Adam Peller

Milestone: 0.9M20.9M1
Resolution: fixed
Status: newclosed
Summary: Port API and JsonItemStore to Dojo 0.9 M1 code split.Port dojo.data API and JsonItemStore to Dojo 0.9 M1 code split.

comment:10 Changed 12 years ago by alex

(In [8154]) super-trivial diff. Refs #2704

comment:11 Changed 12 years ago by (none)

Milestone: 0.9M1

Milestone 0.9M1 deleted

Note: See TracTickets for help on using tickets.