Opened 13 years ago
Closed 8 years ago
#2694 closed enhancement (invalid)
[patch][needs cla] browser.undo supports "preEvent"
| Reported by: | guest | Owned by: | guest |
|---|---|---|---|
| Priority: | high | Milestone: | future |
| Component: | General | Version: | 0.4.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
In browser.undo a state only means one state, but I found it useful if the current state object is also notified when user goes back/forward.
In other words, instead of level triggering, this provides edge triggering, by adding preBack and preForward.
To illustrate the idea... Suppose we have 3 state, 'A', 'B' and 'C', and the current state is 'B'.
When user moves Back, currently it only fires A.back. The patch will makes it fires B.preBack then A.back.
When user moves Forward, currently it only fires C.forward. The patch will makes it fires B.preForward then C.forward.
Attachments (1)
Change History (7)
Changed 13 years ago by
| Attachment: | dojo.undo.browser.patch added |
|---|
comment:1 Changed 12 years ago by
| Owner: | bradneuberg deleted |
|---|
Someone accidentally assigned this to me.
comment:2 Changed 12 years ago by
| Component: | Storage/Flash → General |
|---|---|
| Owner: | set to Ben Lowery |
comment:3 Changed 12 years ago by
| Milestone: | → 1.2 |
|---|
comment:4 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | 1.2 → future |
| Summary: | browser.undo supports "preEvent" → [patch][needs cla] browser.undo supports "preEvent" |
Do we have a CLA for this patch?
Moving undo/back bugs to future until Ben or someone else has time to tackle them.
comment:5 Changed 8 years ago by
| Owner: | changed from Ben Lowery to guest |
|---|---|
| Status: | new → pending |
we need a cla to take this patch. if someone wants to keep this ticket open then make a comment or else it will automatically close in 14 days.
comment:6 Changed 8 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
patch enabling browser.undo pre-event