Opened 12 years ago

Closed 12 years ago

#2686 closed task (fixed)

port style, DOM, and HTML utilities + tests into Base

Reported by: alex Owned by: alex
Priority: high Milestone: 0.9beta
Component: Core Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

as per the roadmap document and refactor.txt, port DOM, style, layout, and other HTML utilities and tests for them into Core.

Change History (28)

comment:1 Changed 12 years ago by alex

(In [7902]) adding a first cut at style, DOM, and html utils. Refs #2686

comment:2 Changed 12 years ago by alex

(In [7903]) ensure that coords() works at least minimally. Refs #2686

comment:3 Changed 12 years ago by alex

(In [7904]) updating style code w/ the APIs Scott and I had agreed on. Updating the NodeList? to use the new (corrected) APIs. Still need to implement style reading and setting. Refs #2686. Refs #2615

comment:4 Changed 12 years ago by alex

(In [7905]) adding quirks-mode tests for HTML namespace. Refs #2686

comment:5 Changed 12 years ago by alex

(In [7918]) IE byId hack only for IE < 7, get/set style properties, and a fix for boxMode calculations typo. Refs #2686. Still needs docs and tests.

comment:6 Changed 12 years ago by alex

(In [7942]) Fake commit. Refs #2686

comment:7 Changed 12 years ago by alex

(In [7964]) fixing strange issues on IE. Refs #2686

comment:8 Changed 12 years ago by alex

(In [7965]) IE is a steaming pile. Refs #2686

comment:9 Changed 12 years ago by alex

(In [7982]) ensure that we get non-pixel-valued styles without casting and ensure that we do it in a compact and relatively performant way. Refs #2686

comment:10 Changed 12 years ago by alex

(In [7984]) ensure that the tests anticipate IE b0rkennes. Fixes more IE6 bone-headedness. Ensures that setting opacity values in IE returns the right value. Refs #2686

comment:11 Changed 12 years ago by alex

(In [7985]) Opera reports computed color styles in #xxxxxx format. Test accordingly. Refs #2686

comment:12 Changed 12 years ago by alex

(In [8042]) implement NodeList?.style() and NodeList?.styles(). Refs #2686

comment:13 Changed 12 years ago by sjmiles

(In [8295]) Rearrange dojo.style so it doesn't call getComputedStyle unless needed. Refs #2686.

comment:14 Changed 12 years ago by alex

(In [8426]) Thanks to Scott Miles for fighting for these methods.

exposing as semi-public:

dojo._setOpacity dojo._getOpacity dojo._getContentBox dojo._setContentBox dojo._getMarginBox dojo._setMarginBox dojo._abs dojo._getOpacity dojo._setOpacity dojo._getPadBorderBounds dojo._getMartinExtents dojo._toPixelValue

Refs #2686

comment:15 Changed 12 years ago by alex

(In [8432]) use indexOf instead of regexp's. Bed-lumping _docScroll. Refs #2686

comment:16 Changed 12 years ago by alex

(In [8433]) dumb mistake. Refs #2686

comment:17 Changed 12 years ago by alex

(In [8434]) another dumb mistake on my part. Refs #2686

comment:18 Changed 12 years ago by alex

(In [8478]) and updated version of html.js from Scott Miles. Passes unit tests and improves performance. Thanks to him for pushing so hard on me to get this right. Refs #2686

comment:19 Changed 12 years ago by alex

(In [8481]) cleanup for bed-lumped names. Refs #2686

comment:20 Changed 12 years ago by alex

(In [8527]) more cleanup from Scott's back-porting. Refs #2686

comment:21 Changed 12 years ago by alex

(In [8535]) fixes weirdness w/ nodes that have display="none" on Safari. Refs #2686. Helps to fix a slew of widget-related breakage on shipping Safari.

comment:22 Changed 12 years ago by sjmiles

(In [8541]) Tweaking the box getters and setters to deal with scrollbars, change boxMode to boxModel, assume border-box on IE5.5. Refs #2686.

comment:23 Changed 12 years ago by sjmiles

(In [8640]) Make _getMarginBox return proper left/top. Refs #2686.

comment:24 Changed 12 years ago by sjmiles

(In [8679]) Make _getMarginBox left/top always be at least 0 (vs. NaN). Refs #2686.

comment:25 Changed 12 years ago by sjmiles

(In [8706]) Change some "this" to "dojo". Library functions are generally callable in any scope. Refs #2686.

comment:26 Changed 12 years ago by alex

(In [8787]) thanks to david schontzler for coming out of retirement to spot some errors in html.js. Refs #2686

comment:27 Changed 12 years ago by sjmiles

(In [9065]) Safari: add a null test and return a golem object from getComputedStyle if necessary. Refs #2686.

Adjust _setContentBox for TABLE and BUTTON, refs #3296.

Move left/top margin box adjustments out of _set and into _get. Refs #3297 and #3320.

Let _getContentBox fall back to offsetWidth/Height if clientWidth/Height are 0. Refs #3378.

comment:28 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

marking fixed. New issues should be filed under separate cover.

Note: See TracTickets for help on using tickets.