Opened 12 years ago

Closed 12 years ago

#2664 closed defect (fixed)

a11y improvements for dijit inlineEditbox

Reported by: Becky Gibson Owned by: ptbrunet
Priority: high Milestone: 0.9beta
Component: Accessibility Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Becky Gibson)

The inlineEditbox needs an ARIA role - specifically the dojoAttachPoint=editable element (which has tabindex=0) needs a role. Assuming that this will always contain a input type=text element, the proper role is textfield. This can be added to the template via waiRole=textfield. This role is needed so the that screenreader will recognized this as an editable field even when it is not being edited.

When the inlineEditBox is disabled, it needs the property of readonly="true" specified. When it is enabled, the property must be removed or set to readonly="false".

Instructions for using this widget should also recommend attaching a label to the editable text. This may be a bit difficult for an inline edit field but is important for screen reader users and should be included whenever possible.

This part of the ticket is no longer necessary. Due to the way the inline editing has been implemented as a wrapper around any type of control we can't easily enable this level of keyboard support. [While there are buttons provided to save and cancel an inline edit, I would also like to see the keyboard implemented for these actions. When editing an inline field pressing escape should cancel the edit and enter should accept the edit. Since the buttons are provided we can technically live with out this but it would make the control more usable for keyboard only and screen reader/screen magnifier users.]

Attachments (1)

InlineEditBox.patch (741 bytes) - added by ptbrunet 12 years ago.
patch adding wai role button to dijitform emplatesInlineEditBox.html

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by Becky Gibson

Description: modified (diff)
Status: newassigned

comment:2 Changed 12 years ago by Becky Gibson

Description: modified (diff)

comment:3 Changed 12 years ago by Becky Gibson

Owner: changed from Becky Gibson to ptbrunet
Status: assignednew

comment:4 Changed 12 years ago by Becky Gibson

Description: modified (diff)

Changed 12 years ago by ptbrunet

Attachment: InlineEditBox.patch added

patch adding wai role button to dijitform emplatesInlineEditBox.html

comment:5 Changed 12 years ago by ptbrunet

WAI role of button was added. Using Window-Eyes the behavior with an inline editbox wrapping an input tag is: in browse mode move to the inlineEditBox. You will hear the content and "button". If you press enter, focus will be placed on the text and you will hear "browse off", the content, and "button". Since you heard "button" and since the text should say something about clicking, a natural thing would be to press enter again. The dojo behavior for an inline editbox wrapping a textarea tag is almost the same (with some focus problems which will be fixed in another bug trac).

The WAI role of textfield with a state of readonly was tried but the behavior was not as good as when using a role of button.

comment:6 Changed 12 years ago by ptbrunet

Status: newassigned

A patch is attached to add a WAI role of button to the template.

comment:7 Changed 12 years ago by Becky Gibson

Resolution: fixed
Status: assignedclosed

(In [9283]) commit for ptbrunet (CLA via IBM). add button role to inlineedit box fixes #2664

Note: See TracTickets for help on using tickets.