dojo.raise() calls println() even when exception is caught

[Brian Douglas Skinner <openrecord@…>]

dojo.raise() always calls dojo.hostenv.println("FATAL"), regardless of whether the exception is caught and squelched.

For example, if you do this, you still get a "FATAL" message:

  try {
    dojo.raise("wanh");
  } catch (e) {
    tryAgian = true; // not fatal, so we squelch
  }

Would it be better to do the println("FATAL") call in some top level error handler? For example, if dojo is running in a browser, it could set window.onerror=dojo.errorHandler(), which should only get called if the exception has not been caught and squelched.

[Adam Peller]

The proposed solution will not be precise, as a caught exception may still get reported later if an onerror condition occurs; the exception report will be stale. In some ways this is an improvement over reporting the exception always when it is caught, though the timing will be off, further complicating debugging.

The only other solution I can think of, besides WONTFIX, is to change the println to indicate "FATAL exception raised" so it's not as misleading.

[skinner]

What about having some config variable that allows somebody to optionally turn off that println("FATAL")?

djConfig.verboseExceptions = false;

That would make it possible to squelch bogus FATAL messages in some scenarios, while still not messing up people who rely on the println("FATAL") being there.

Or, maybe another option is to just use the existing djConfig.isDebug...

dojo.raise = function(/*String*/ message, /*Error?*/ exception){
	if(exception){
		message = message + ": "+dojo.errorToString(exception);
	}
	if (djConfig.isDebug) {
		try {	dojo.hostenv.println("FATAL: "+message); } catch (e) {}
	}

	throw Error(message);
}

[Adam Peller]

(In [5779]) Change dojo.raise() to rethrow exception, only print FATAL "exception raised" message for isDebug. Fixes #264 and #1410

[(none)]

Milestone 0.4 deleted