Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#2618 closed defect (wontfix)

FilteringTable incorrectly identifies dataType for columns in fillCell method

Reported by: eric.foster-johnson@… Owned by: Tom Trenka
Priority: high Milestone: 0.9
Component: Dijit Version: 0.4.2
Keywords: FilteringTable widgets Cc:
Blocked By: Blocking:

Description

(Note this has nothing to do with numeric formatting. Instead, this is an issue with identifying the column is of a numeric dataType.)

In the fillCell function in FilteringTable?.js in Dojo 0.4.2 at approx. line 733, you see the following construct (unchanged from 0.4.1):

} else if ("Number number int Integer float Float".indexOf(meta.getType())>-1){

The problem here is that if you specify a dataType="Number" on the column, meta.getType() returns the function Number(), not a text string. Hence, this else block never gets executed and the code does not correctly identify that the column has a dataType of "Number".

If I replace the line with:

} else if (meta.getType() == Number) {

Then the block will get executed.

Change History (3)

comment:1 Changed 12 years ago by eric.foster-johnson@…

That is line 492 in 0.4.2. Sorry. Same file, same issue, though.

comment:2 Changed 12 years ago by bill

Component: WidgetsDijit
Milestone: 0.9
Owner: changed from bill to Tom Trenka

Should be fixed w/new Table widget.

comment:3 Changed 12 years ago by Tom Trenka

Resolution: wontfix
Status: newclosed

FilteringTable? is not being ported to either Dijit or DojoX, so I'm closing the bug.

Note: See TracTickets for help on using tickets.