Opened 13 years ago

Closed 12 years ago

Last modified 10 years ago

#2615 closed task (fixed)

port dojo.query/dojo.NodeList + tests into core

Reported by: alex Owned by: alex
Priority: high Milestone:
Component: Query Version: 0.4.1
Keywords: query, NodeList Cc:
Blocked By: Blocking:

Description

as per the roadmap document and refactor.txt, port dojo.query and dojo.NodeList? and tests for them into Core. Also, fill in the incomplete dojo.NodeList? methods.

Attachments (1)

2615.patch (5.3 KB) - added by James Burke 12 years ago.
Change in function declarations so they survive compression during a build.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 13 years ago by alex

(In [7698]) brings NodeList? and query() up to date. I'm surprised at how small the diff is. Still need to bring in/write tests for them. Refs #2615

comment:2 Changed 12 years ago by alex

(In [7845]) refs #2615

comment:3 Changed 12 years ago by alex

(In [7846]) include query() tests. Refs #2615

comment:4 Changed 12 years ago by alex

(In [7883]) tests and correctness fixes for dojo.query(). This is something of a backslide on performance, but correctness trumps. Still need to find another week or so to spend on query(). Refs #2615.

comment:5 Changed 12 years ago by alex

(In [7888]) beginning of tests for the NodeList? class. Refs #2615

comment:6 Changed 12 years ago by alex

(In [7891]) more correctness fixes for non-xpath code paths. Refs #2615.

comment:7 Changed 12 years ago by alex

(In [7904]) updating style code w/ the APIs Scott and I had agreed on. Updating the NodeList? to use the new (corrected) APIs. Still need to implement style reading and setting. Refs #2686. Refs #2615

comment:8 Changed 12 years ago by alex

(In [7960]) un-fscking NodeList?.filter(). Push was pushing *all* the args. Refs #2615

comment:9 Changed 12 years ago by alex

(In [7977]) correctly scope queries. Not sure how I'd missed this. Guess we need more tests for query(). Refs #2615

Changed 12 years ago by James Burke

Attachment: 2615.patch added

Change in function declarations so they survive compression during a build.

comment:10 Changed 12 years ago by alex

(In [8002]) code re-ordering to survive the build. M1 tests now pass post-build. Refs #2615. Obsoletes the attached patch.

comment:11 Changed 12 years ago by alex

NOTE: still need comprehensive tests for query including parenting. Also, NodeList? is still fairly untested. Need to fix these before we can close.

comment:12 Changed 12 years ago by alex

(In [8151]) more NodeList? tests. Refs #2615

comment:13 Changed 12 years ago by alex

(In [8153]) ensuring that we exercise all the filter() argument sets. Refs #2615

comment:14 Changed 12 years ago by alex

Type: defecttask

comment:15 Changed 12 years ago by alex

(In [8156]) changing the returns of NodeList?'s style() and styles() functions. Returning a NodeList? from them is idiotic. Refs #2615

comment:16 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

(In [8544]) fixes issues w/ context nodes + "> ..." rules. Fixes #2615. New issues on query should be filed under separate cover.

comment:17 Changed 12 years ago by alex

(In [8577]) make sure that the NodeList? tests don't bring up the firebug list console when fired up stand-alone. We don't want to screw the results. Refs #2615

comment:18 Changed 12 years ago by (none)

Milestone: 0.9M2

Milestone 0.9M2 deleted

comment:19 Changed 12 years ago by alex

(In [8966]) add a connect() method to NodeList? so we don't have to do so much forEach()-ing to set up a behavior. Refs #2615

comment:20 Changed 12 years ago by alex

(In [9218]) provide animation for node lists. Refs #2615

comment:21 Changed 12 years ago by alex

(In [9219]) was missing a passthrough arg. Refs #2615

comment:22 Changed 10 years ago by bill

Component: CoreQuery
Note: See TracTickets for help on using tickets.