#2606 closed defect (fixed)
build process does not strip dojo.requireIf statements
| Reported by: | James Burke | Owned by: | James Burke |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | BuildSystem | Version: | 0.4.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
This happens in 0.4.2.
Steps to reproduce:
- Build dojo using the buildscripts/profiles/charting.profile.js profile.
- After the build is done, open tests/charting/test_engine.html
- Look at the Firebug console. You will see some requests for some svg modules, but they are already included in dojo.js.
The build process should be removing dojo.requireIf() calls if the module that is referenced by the dojo.requireIf() call is in the built dojo.js.
Change History (9)
comment:1 Changed 13 years ago by
| Milestone: | → 0.9M1 |
|---|
comment:2 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 13 years ago by
| Resolution: | → fixed |
|---|
comment:4 Changed 13 years ago by
| Milestone: | 0.9M1 → 0.4.3 |
|---|
comment:5 Changed 13 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Reopening -- this change is too aggressive: it seems to be removing all requireIf statements, but it should only remove the ones for modules that are in the built file.
comment:6 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:7 Changed 13 years ago by
| Resolution: | → fixed |
|---|
comment:8 Changed 13 years ago by
| Resolution: | → fixed |
|---|
Note: See
TracTickets for help on using
tickets.
(In [7629]) Fixes #2606, dojo.requireIf calls not being stripped from built dojo.js