Opened 12 years ago

Closed 12 years ago

#2602 closed enhancement (wontfix)

build: strip-resource-comments spits out scary errors.

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.0
Component: BuildSystem Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

Right now the strip-resource-comments spits out some scary exceptions when stripping comments from a file. These exceptions come from Rhino when it does not like the javascript. All of the errors are in files that are not used by the browser-based dojo, but they should be either fixed or make the printout just say "skipping file x because of blah blah".

Change History (3)

comment:1 Changed 12 years ago by James Burke

Milestone: 0.9beta0.9

Moving to 0.9. Not a super-critical thing, more of a refinement in the build system interface.

comment:2 Changed 12 years ago by James Burke

Milestone: 0.91.0

Not critical for 0.9. Moving to 1.0

comment:3 Changed 12 years ago by James Burke

Resolution: wontfix
Status: newclosed

Not going to fix this: this was an issue more with the 0.4 codebase, where some modules had some unusual javascript and/or javascript snippets. The 0.9 codebase is a lot cleaner, so this is not an issue for the dojo code. It is probably good to keep the scary warning in there for 3rd party code to indicate that there is a problem.

Note: See TracTickets for help on using tickets.