Opened 15 years ago

Closed 13 years ago

#2585 closed enhancement (fixed)

Consider making inter-strings and/or widget template loading smarter about empty template files.

Reported by: James Burke Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Right now if a template (either templatePath or templateCssPath) is an empty file, intern strings will put in an empty file, but the logic in DomWidget?, seeing an empty value (equates to false) will try to load the template at runtime.

This is normally bad in an xdomain situation, where the template cannot be loaded via XHR.

Maybe it is enough to make DomWidget? smarter about the value checking of the string (if the templateString/templateCssString property is defined but an empty string, do not try to load the template via XHR).

This is a protection against odd development cases, so I see it more as an enhancement.

Change History (5)

comment:1 Changed 15 years ago by bill

Component: WidgetsDijit
Milestone: 1.0

comment:2 Changed 15 years ago by bill

Milestone: 1.02.0

comment:3 Changed 14 years ago by alex

Milestone: 2.01.3

Milestone 2.0 deleted

comment:4 Changed 14 years ago by bill

Milestone: 1.31.4

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

comment:5 Changed 13 years ago by bill

Description: modified (diff)
Resolution: fixed
Status: newclosed

This is no longer an issue now that we've switched everything to use templateString: dojo.cache() ...

Note: See TracTickets for help on using tickets.