Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2583 closed defect (fixed)

tests/widget/test_Editor2.html "styleValue has no properties" error in 0.4.2rc2

Reported by: James Burke Owned by: sjmiles
Priority: high Milestone:
Component: Style Version: 0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

Seems to be a problem with the new dojo.html.getComputedStyle function definition (or related changes to html/style.js). The problem happens in trunk too. I think it might be related to r7379 (r7465 for 0.4 branch). By reverting to a version of style.js before that commit, the error goes away.

Change History (6)

comment:1 Changed 12 years ago by James Burke

I was testing with FF 2.0.0.2, and someone else reported the problem with FF 1.5.

comment:2 Changed 12 years ago by sjmiles

Owner: changed from anonymous to sjmiles

comment:3 Changed 12 years ago by sjmiles

(In [7577]) Added a null-input test to non-IE version of toPixelValue, references #2583.

comment:4 Changed 12 years ago by sjmiles

Resolution: → fixed
Status: new → closed

Note that this problem indicates (what is IMO) a bug in RichText?.js which is sending a bad node to getPixelValue. See the implementation of isSignificantNode in RichText?.js. In particular, certain nodes with nodeType==3 are considered "significant", although no such node actually has a style property afaik (at least on FF).

comment:5 Changed 12 years ago by James Burke

Resolution: → fixed

(In [7583]) (merge from trunk) Fixes #2583

comment:6 Changed 12 years ago by (none)

Milestone: 0.4.2

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.