[cla] [Patch] Allows DropDown[Date|Time]Picker to disable keyboard entry but not dropDown one

[guest]

If we don't want user can input in the field but just allow him to use the drop down. Here is the patch :

Index: /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownDatePicker.js
===================================================================
--- /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownDatePicker.js	(revision 1804)
+++ /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownDatePicker.js	(working copy)
@@ -92,6 +92,9 @@
 		//	disable all incremental controls, must pick a date in the current display
 		staticDisplay: false,
 		
+		//If true disabled the input from keyboard
+		inputNotAllowed:false,
+		
 		templatePath:  dojo.uri.dojoUri("src/widget/templates/DatePicker.htm"),
 		templateCssPath:  dojo.uri.dojoUri("src/widget/templates/DatePicker.css"),
 		
@@ -137,6 +140,9 @@
 			this.containerNode.style.zIndex = this.zIndex;
 			this.containerNode.explodeClassName = "calendarBodyContainer";
 			this.valueNode.name=this.name;
+			
+			//Can disable the input if inputNotAllowed = true
+			this.inputNode.disabled = this.inputNotAllowed;
 		},
 
 		getValue: function(){
@@ -221,7 +227,8 @@
 		},
 		
 		enable: function() {
-			this.inputNode.disabled = false;
+			//Can disable the input if inputNotAllowed = true
+			this.inputNode.disabled = this.inputNotAllowed;
 			this.datePicker.enable();
 			dojo.widget.DropdownDatePicker.superclass.enable.apply(this, arguments);
 		},
Index: /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownTimePicker.js
===================================================================
--- /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownTimePicker.js	(revision 1804)
+++ /Users/doume/Dev/Wicket/branch-1X/wicket-contrib-dojo/src/main/java/wicket/contrib/dojo/dojo-0.4/src/widget/DropdownTimePicker.js	(working copy)
@@ -54,6 +54,8 @@
 		// 	name of the form element, used to create a hidden field by this name for form element submission.
 		name: "",
 		
+		//If true disabled the input from keyboard
+		inputNotAllowed:false,
 		
 		templatePath: dojo.uri.dojoUri("src/widget/templates/TimePicker.htm"),
 		templateCssPath: dojo.uri.dojoUri("src/widget/templates/TimePicker.css"),
@@ -85,6 +87,9 @@
 			}
 			this.valueNode.name=this.name;
 			this.inputNode.name=this.name;
+			
+			//Can disable the input if inputNotAllowed = true
+			this.inputNode.disabled = this.inputNotAllowed;
 		},
 		
 		onSetTime: function(){
@@ -113,7 +118,8 @@
 		
 		enable: function() {
 			// summary: enable this widget to accept user input
-			this.inputNode.disabled = false;
+			//Can disable the input if inputNotAllowed = true
+			this.inputNode.disabled = this.inputNotAllowed;
 			this.timePicker.enable();
 			dojo.widget.DropdownTimePicker.superclass.enable.apply(this, arguments);
 		},

[[email protected]…]

Ooops sorry, I've forgotten my email adresse ;)

[Adam Peller]

worth implementing in dijit.DateTextbox??

[Douglas Hays]

Need to add the readOnly attribute to the visible input element.

[bill]

Hi. Sorry, but I'm gonna mark this as "wontfix". The problem is that for accessibility reasons you need to be able to type in a date/time directly, since the new Calendar widget isn't accessible.

[Adam Peller]

I'm not sure the a11y concern applies here, Bill. If the widget is disabled, the Calendar is superfluous.

Do we allow disabling the widget? If yes, we must disable either the dropdown or the calendar selection. If not, then I guess there's no bug.

[bill]

We allow disabling the widget... meaning that the user can't change the value.. but this enhancement is about just disabling keyboard input into the <input> box, but still allowing the user to pick a value from the drop down.