InlineEditBox onUndo callback never called

[guest]

As per the documentation and comments in the code, when the cancel button is clicked the onUndo() callback should be called but it is not ever. Looking at the code onUndo() is only called through undo(), and undo is never called. QED.

[guest]

If you need more info about this bug report please contact jeffg at inventivity.com

[[email protected]…]

If you want to know if the cancel button is pushed, use cancelEdit()

[[email protected]…]

patch, changes test, and fixes all callbacks...

[alex]

applied in [7547]. Thanks for the quick turnaround on the patch.

[[email protected]…]

A few key things: I think "name" should be passed to each callback, not just onSave... Now that onCancel actually exists and is called (where before it wasn't), this needs to be done to be consistent. OnChange? is now called even if no change by the user is made... I suggest this is unneccesary. My suggestion is to simplify this interface while keeping maximal flexibility by replacing the now 3 callback functions into just 1 callback as follows:

onCompletion( whichButtonPressed, newValue, oldValue, name ) { whichButtonPressed will be true for 'save' or false for 'cancel' user can compare old & new values to see if anything changed and 'name' is the context the user provides or null otherwise }

of course for backwards compatiblity you leave onSave() as is, though deprecate it

[alex]

moving to 0.4.3 for further discussion. The patches applied to date made it into 0.4.2.

[Douglas Hays]

There is no Undo function (separate from Cancel) in the 0.9 InlineEditBox?. Changing this to enhancement until its decided if there should be that function. onValueChanged() will be called when the value changes. onClick will be called when editing begins.

[Douglas Hays]

InlineEditBox? being redesigned by bill

[bill]

OK, in the new dijit.InlineEditBox? there's a cancel() method that you can connect to (<script type="dojo/connect">) to find out when the user cancels.