#2556 closed defect (fixed)
event.stopEvent method causes error on IE when using frames
Reported by: | guest | Owned by: | alex |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | Events | Version: | 0.4.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
When the event originates from a different window then window.event is null and therefor in
if(window.event){ evt.cancelBubble = true; evt.returnValue = false; }else{ evt.preventDefault(); evt.stopPropagation(); }
the else block is executed which yields a "Object doesn't support this property or method" error.
I think the "if" clause should be changed to
if(typeof(window.event) == "undefined"){ ...
Change History (6)
comment:1 Changed 13 years ago by
Milestone: | → 0.9 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Farther down in the file we have:
365 // override stopEvent for IE 366 dojo.stopEvent = function(evt){ 367 evt = evt || window.event;
So the documentation was actually correct, although (afaik) it's an open question how the documentation engine handles such overrides.
comment:5 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
In 0.9 this code has been changed to:
Looks fixed. The comment is obviously wrong though so I'll fix that.