Opened 14 years ago
Closed 13 years ago
#2542 closed defect (fixed)
[dojo.data] change datastores to use SimpleBaseStore
Reported by: | skinner | Owned by: | Jared Jurkiewicz |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Data | Version: | 0.4.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
We should convert a lot of the dojo.data datastores to inherit from dojo.data.core.SimpleBaseStore?. A number of our older datastore implementations were written back before SimpleBaseStore? existed. Now that we have SimpleBaseStore?, we should use it as a standard abstract superclass for most of those older datastores. The datastores implementations will be simpler and more consistent after the change.
Here's what that current inheritance hierarchy looks like:
+ OpmlStore extends nothing + SimpleBaseStore extends nothing + JsonItemStore extends SimpleBaseStore + RemoteStore extends nothing + CsvStore extends RemoteStore + DeliciousStore extends RemoteStore + YahooStore extends RemoteStore + RdfStore extends RemoteStore
Here's what I think a better inheritance hierarchy would look like:
+ SimpleBaseStore extends nothing + JsonItemStore extends SimpleBaseStore + OpmlStore extends SimpleBaseStore + CsvStore extends SimpleBaseStore + DeliciousStore extends SimpleBaseStore + YahooStore extends SimpleBaseStore + RemoteStore extends SimpleBaseStore + RdfStore extends RemoteStore
Attachments (7)
Change History (17)
Changed 14 years ago by
Attachment: | dojo.data.util.simpleFetch_20070429.patch added |
---|
Changed 14 years ago by
Attachment: | dojo.data.util.sorter_20070429.patch added |
---|
Modified basicComparator to handle undefined values
Changed 14 years ago by
Attachment: | dojox.data.CsvStore_20070429.patch added |
---|
First implementation of the CsvStore? in the dojox branch, includes UT
comment:1 Changed 14 years ago by
The three patches uploaded on 4/29 were created by me (Michael Smith, msmith [CLA]).
This is the initial port of CsvStore? into dojox, using simpleFetch as a mixin class for the CsvStore?.
The modification to basicComparator is required for the "sort" Unit Tests to pass.
Data types are not yet implemented, so sorting numbers is lexicographic.
~Michael Smith (msmith)
Changed 14 years ago by
Attachment: | dojo.data.api.Read_20070501.patch added |
---|
Two trivial corrections to documentation on the dojo.data.api.Read interface.
Changed 14 years ago by
Attachment: | dojox.data.CsvStore_20070501.patch added |
---|
Second revision of dojox.data.CsvStore? implementation.
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
comment:5 Changed 14 years ago by
Changed 14 years ago by
Attachment: | dojox.data.OpmlStore_20070515.patch added |
---|
OpmlStore? patch and UT files
comment:6 Changed 14 years ago by
Attached the OpmlStore? patch with unit tests. This is a first pass patch that will probably need to be updated before committing it into dojox.
~Michael Smith (msmith)
Changed 14 years ago by
Attachment: | dojox.data.OpmlStore_20070518.patch added |
---|
Round 2 of the OpmlStore? implementation
comment:7 Changed 14 years ago by
comment:8 Changed 14 years ago by
Owner: | changed from skinner to Jared Jurkiewicz |
---|
comment:9 Changed 14 years ago by
Milestone: | 0.9 → 1.0 |
---|
Changing this to 1.0. We've ported the main stores over and added Flickr. so delicious isn't as important now and could be ported in 1.0 timeframe.
comment:10 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
We've proted everything I think we're going to port for now. Closing thos.
Corrected documentation in the simpleFetch utility function