Opened 13 years ago

Closed 12 years ago

#2542 closed defect (fixed)

[dojo.data] change datastores to use SimpleBaseStore

Reported by: skinner Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.0
Component: Data Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

We should convert a lot of the dojo.data datastores to inherit from dojo.data.core.SimpleBaseStore?. A number of our older datastore implementations were written back before SimpleBaseStore? existed. Now that we have SimpleBaseStore?, we should use it as a standard abstract superclass for most of those older datastores. The datastores implementations will be simpler and more consistent after the change.

Here's what that current inheritance hierarchy looks like:

+ OpmlStore extends nothing
+ SimpleBaseStore extends nothing
   + JsonItemStore extends SimpleBaseStore
+ RemoteStore extends nothing
   + CsvStore extends RemoteStore
   + DeliciousStore extends RemoteStore
   + YahooStore extends RemoteStore 
   + RdfStore extends RemoteStore 

Here's what I think a better inheritance hierarchy would look like:

+ SimpleBaseStore extends nothing
   + JsonItemStore extends SimpleBaseStore
   + OpmlStore extends SimpleBaseStore
   + CsvStore extends SimpleBaseStore
   + DeliciousStore extends SimpleBaseStore
   + YahooStore extends SimpleBaseStore
   + RemoteStore extends SimpleBaseStore 
      + RdfStore extends RemoteStore 

Attachments (7)

dojo.data.util.simpleFetch_20070429.patch (1.5 KB) - added by guest 13 years ago.
Corrected documentation in the simpleFetch utility function
dojo.data.util.sorter_20070429.patch (772 bytes) - added by guest 13 years ago.
Modified basicComparator to handle undefined values
dojox.data.CsvStore_20070429.patch (42.4 KB) - added by guest 13 years ago.
First implementation of the CsvStore? in the dojox branch, includes UT
dojo.data.api.Read_20070501.patch (1.3 KB) - added by guest 13 years ago.
Two trivial corrections to documentation on the dojo.data.api.Read interface.
dojox.data.CsvStore_20070501.patch (43.0 KB) - added by guest 13 years ago.
Second revision of dojox.data.CsvStore? implementation.
dojox.data.OpmlStore_20070515.patch (38.0 KB) - added by guest 13 years ago.
OpmlStore? patch and UT files
dojox.data.OpmlStore_20070518.patch (38.1 KB) - added by guest 13 years ago.
Round 2 of the OpmlStore? implementation

Download all attachments as: .zip

Change History (17)

Changed 13 years ago by guest

Corrected documentation in the simpleFetch utility function

Changed 13 years ago by guest

Modified basicComparator to handle undefined values

Changed 13 years ago by guest

First implementation of the CsvStore? in the dojox branch, includes UT

comment:1 Changed 13 years ago by guest

The three patches uploaded on 4/29 were created by me (Michael Smith, msmith [CLA]).

This is the initial port of CsvStore? into dojox, using simpleFetch as a mixin class for the CsvStore?.

The modification to basicComparator is required for the "sort" Unit Tests to pass.

Data types are not yet implemented, so sorting numbers is lexicographic.

~Michael Smith (msmith)

Changed 13 years ago by guest

Two trivial corrections to documentation on the dojo.data.api.Read interface.

Changed 13 years ago by guest

Second revision of dojox.data.CsvStore? implementation.

comment:2 Changed 13 years ago by guest

Two more patches uploaded by Michael Smith (msmith).

comment:3 Changed 13 years ago by Jared Jurkiewicz

(In [8397]) Applying two patches from Michael Smith for minor documentation updates (dojo.data.util.simpleFetch_20070429.patch and dojo.data.api.Read_20070501.patch). refs #2542

comment:4 Changed 13 years ago by Jared Jurkiewicz

(In [8398]) Committing in Michael Smith patch for CsvStore? port to dojox.data and UT. Minor updtae to patch by Jaredj to remove a couple bits of whitespace. refs #2542

comment:5 Changed 13 years ago by Jared Jurkiewicz

The CsvStore? addition was tested against:

Windows: Firefox 2.0.0.3 Firefox 1.5.0.11 IE 6 IE 7 Opera 9.2

OS-X: WebKit?

Changed 13 years ago by guest

OpmlStore? patch and UT files

comment:6 Changed 13 years ago by guest

Attached the OpmlStore? patch with unit tests. This is a first pass patch that will probably need to be updated before committing it into dojox.

~Michael Smith (msmith)

Changed 13 years ago by guest

Round 2 of the OpmlStore? implementation

comment:7 Changed 13 years ago by Jared Jurkiewicz

(In [8670]) Commit of theOpmlStore patch from Michael Smith. refs #2542

comment:8 Changed 12 years ago by Jared Jurkiewicz

Owner: changed from skinner to Jared Jurkiewicz

comment:9 Changed 12 years ago by Jared Jurkiewicz

Milestone: 0.91.0

Changing this to 1.0. We've ported the main stores over and added Flickr. so delicious isn't as important now and could be ported in 1.0 timeframe.

comment:10 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

We've proted everything I think we're going to port for now. Closing thos.

Note: See TracTickets for help on using tickets.