Opened 15 years ago

Closed 10 years ago

#2536 closed defect (invalid)

dojo.requireIf fails in custom build with parentheses condition

Reported by: [email protected] Owned by: [email protected]
Priority: high Milestone: future
Component: BuildSystem Version: 0.4.2rc1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by James Burke)

In a source file, doing dojo.requireIf( (!(a && a.b)), "a.b") returns an error during the build "exception: SyntaxError?: missing ) after argument list". (rev 7517)

Refactoring the requireIf statement to look like: dojo.requireIf( !a || !a.b, "a.b") works fine. (ie. remove the parentheses)

I assume its a regexp somewhere which isn't being greedy enough, but I couldn't seem to find the correct one in buildUtil.js.

Change History (6)

comment:1 Changed 14 years ago by James Burke

Milestone: 1.0

comment:2 Changed 14 years ago by James Burke

Milestone: 1.01.1

See #4462: it might have a parens matching code change, and if so, it should solve this issue. Pushing to 1.1, with #4462.

comment:3 Changed 14 years ago by James Burke

Milestone: 1.11.2

comment:4 Changed 14 years ago by James Burke

Description: modified (diff)
Milestone: 1.2future

comment:5 Changed 10 years ago by ben hockey

Owner: changed from James Burke to [email protected]
Status: newpending

is this issue still relevant?

comment:6 Changed 10 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.