Opened 13 years ago

Closed 12 years ago

#2517 closed enhancement (wontfix)

Possible efficiency improvement for chart lines in VML

Reported by: Andrew.Thomas@… Owned by: Tom Trenka
Priority: high Milestone:
Component: Charting Version: 0.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

In dojo/src/charging/vml/Plotters.js, line 536 (the Line: plotter) there is:

if (i==0){

cmd.push("m"); cmd.push(x+","+y);

}else{

cmd.push("l"); cmd.push(x+","+y);

}

My reading of the VML spec suggests that the following is equally correct, and results in a shorter command set. It works in IE7.

if (i==0){

cmd.push("m");

}else if (i==1){

cmd.push("l");

}else{

cmd.push(x+","+y);

Change History (2)

comment:1 Changed 13 years ago by Andrew.Thomas@…

Oops - typo. The last else{ should not be there. The cmd.push(x+","+y) at the end should be unconditional.

comment:2 Changed 12 years ago by Tom Trenka

Resolution: wontfix
Status: newclosed

Going to close this; porting charting to use dojox.gfx, and that efficiency is abstracted there.

Note: See TracTickets for help on using tickets.